Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename RTP.TCP.Depayloader to RTP.RTSP.Decapsulator #162

Merged
merged 7 commits into from
Feb 23, 2024
Merged

Rename RTP.TCP.Depayloader to RTP.RTSP.Decapsulator #162

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d243ffe
Rename RTP.TCP.Depayloader to RTP.RTSP.Depayloader
Noarkhh Feb 21, 2024
bff9395
Bump version
Noarkhh Feb 21, 2024
0bb37d5
Add basic tests
Noarkhh Feb 23, 2024
bbab9d0
Rename to decapsulator
Noarkhh Feb 23, 2024
f6d8c3e
Fix test
Noarkhh Feb 23, 2024
088936e
Satisfy credo
Noarkhh Feb 23, 2024
bf50ec9
Apply reviewers suggestion
Noarkhh Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ The package can be installed by adding `membrane_rtp_plugin` to your list of dep
```elixir
def deps do
[
{:membrane_rtp_plugin, "~> 0.25.0"},
{:membrane_rtp_plugin, "~> 0.26.0"},
{:ex_libsrtp, ">= 0.0.0"} # required only if SRTP/SRTCP support is needed
]
end
Expand Down
5 changes: 3 additions & 2 deletions lib/membrane/rtp/tcp_depayloader.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
defmodule Membrane.RTP.TCP.Depayloader do
defmodule Membrane.RTP.RTSP.Depayloader do
Copy link
Contributor

@wkozyra95 wkozyra95 Feb 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR name does not match the change (and file name)

@moduledoc """
This element provides functionality of depayloading RTP Packets received by TCP and redirecting
RTSP messages received in the same stream. The encapsulation is described in RFC 7826 Section 14.
RTSP messages received in the same stream established with RTSP. The encapsulation is described
in RFC 7826 Section 14.

Encapsulated packets interleaved in the stream will have the following structure:
["$" = 36 :: 1 byte][Channel id :: 1 byte][Length :: 2 bytes][packet :: <Length> bytes]
Expand Down
2 changes: 1 addition & 1 deletion mix.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
defmodule Membrane.RTP.Plugin.MixProject do
use Mix.Project

@version "0.25.0"
@version "0.26.0"
@github_url "https://github.com/membraneframework/membrane_rtp_plugin"

def project do
Expand Down