Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for TCP transport (interleaving) #51

Open
maslowalex opened this issue Feb 25, 2025 · 3 comments
Open

Support for TCP transport (interleaving) #51

maslowalex opened this issue Feb 25, 2025 · 3 comments

Comments

@maslowalex
Copy link

Hi! Thank you for a great library!

I'm interested in adding the support for TCP transport and I wanted to ask for your support to not spend much time refactoring the code.

Could you elaborate on your vision, maybe with the changes required to make this happen. This would help me spend less time on refactoring / aligning the code with your vision.

Looking forward to your input @gBillal 🙏

@gBillal
Copy link
Contributor

gBillal commented Feb 25, 2025

@maslowalex just to be sure, we are talking about tcp support for record method ?

@maslowalex
Copy link
Author

@maslowalex just to be sure, we are talking about tcp support for record method ?

Absolutely. Also known as push approach.

@gBillal
Copy link
Contributor

gBillal commented Feb 25, 2025

I think there's two issues that needs to be addressed

  • When a user is recording using tcp, the server should not attempt to read from the socket. A field recording? in the client connection may be sufficient to handle this case.
  • The second issue is to forward rtsp messages by the handler to the server. We can use a simple send(conn_pid, {:rtsp_message, message}) and handle it. I wonder if there's a better api to expose for this use case. The pid can be retrieved easily in the handler by using self().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants