Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for announce and record to server #48

Merged
merged 7 commits into from
Jan 21, 2025

Conversation

gBillal
Copy link
Contributor

@gBillal gBillal commented Dec 22, 2024

Add support for publishing media streams to an RTSP server. In this PR only udp transport is supported. We'll add tcp support in a future PR (it needs some thinking since recording with tcp means receiving rtsp messages will be the responsibility of the handler and not the server anymore).

I'll add later on an example of a PubSub Server where someone is publishing a stream and others streaming it.

@mat-hek mat-hek requested a review from Noarkhh December 23, 2024 11:02
@Noarkhh
Copy link
Contributor

Noarkhh commented Jan 21, 2025

Hi @gBillal, could you please push any commit to this branch? I changed our CI config, so that it should trigger on PRs from forks.

@gBillal gBillal requested a review from Noarkhh January 21, 2025 11:32
@Noarkhh
Copy link
Contributor

Noarkhh commented Jan 21, 2025

Would it be feasible for you to add an example livebook, where the recording functionality is used? The basic_server.livemd example is nice and to have another one that shows how to publish streams to a server would be be nice too.

@gBillal
Copy link
Contributor Author

gBillal commented Jan 21, 2025

@Noarkhh I'm working on an example like that, however it's not as easy as the basic_server.livemd, so I think I'll add it to the membrane_demo repo.

@Noarkhh
Copy link
Contributor

Noarkhh commented Jan 21, 2025

Okay, good to hear :) I'll be waiting for the PR

@Noarkhh Noarkhh merged commit 0582419 into membraneframework:master Jan 21, 2025
3 checks passed
@gBillal gBillal deleted the server-record-support branch January 21, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants