Refactor live render attrs

membraneframework · Mar 3, 2025 · bc136cd · bc136cd
1 parent 4b3be44
commit bc136cd
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/example_project/lib/example_project_web/live/echo.ex b/example_project/lib/example_project_web/live/echo.ex
@@ -37,10 +37,10 @@ defmodule ExampleProjectWeb.Live.EchoLive do
   def render(assigns) do
     ~H"""
     <h3>Captured stream preview</h3>
-    <Capture.live_render socket={@socket} capture="mediaCapture" />
+    <Capture.live_render socket={@socket} capture_id="mediaCapture" />
 
     <h3>Stream sent by the server</h3>
-    <Player.live_render socket={@socket} player="videoPlayer" />
+    <Player.live_render socket={@socket} player_id="videoPlayer" />
     """
   end
 end
diff --git a/lib/membrane_webrtc_live/capture.ex b/lib/membrane_webrtc_live/capture.ex
@@ -61,7 +61,7 @@ defmodule Membrane.WebRTC.Live.Capture do
 
   attr(:socket, Phoenix.LiveView.Socket, required: true, doc: "Parent live view socket")
 
-  attr(:capture, :string,
+  attr(:capture_id, :string,
     required: true,
     doc: """
     #{inspect(__MODULE__)} struct. It is used to pass capture id to the newly created live view via live view session.
@@ -78,7 +78,7 @@ defmodule Membrane.WebRTC.Live.Capture do
   @spec live_render(map()) :: live_view when live_view: term()
   def live_render(assigns) do
     ~H"""
-    <%= live_render(@socket, __MODULE__, id: "#{@capture}-lv", session: %{"class" => @class, "id" => @capture}) %>
+    <%= live_render(@socket, __MODULE__, id: "#{@capture_id}-lv", session: %{"class" => @class, "id" => @capture_id}) %>
     """
   end
 

diff --git a/lib/membrane_webrtc_live/player.ex b/lib/membrane_webrtc_live/player.ex
@@ -62,7 +62,7 @@ defmodule Membrane.WebRTC.Live.Player do
 
   attr(:socket, Phoenix.LiveView.Socket, required: true, doc: "Parent live view socket")
 
-  attr(:player, :string,
+  attr(:player_id, :string,
     required: true,
     doc: """
     #{inspect(__MODULE__)} struct. It is used to pass player id to the newly created live view via live view session.
@@ -79,7 +79,7 @@ defmodule Membrane.WebRTC.Live.Player do
   @spec live_render(map()) :: live_view when live_view: term()
   def live_render(assigns) do
     ~H"""
-    <%= live_render(@socket, __MODULE__, id: "#{@player}-lv", session: %{"class" => @class, "id" => @player}) %>
+    <%= live_render(@socket, __MODULE__, id: "#{@player_id}-lv", session: %{"class" => @class, "id" => @player_id}) %>
     """
   end