From bc136cd5fda380d9df6f740bb2f923bca21c385b Mon Sep 17 00:00:00 2001 From: "feliks.pobiedzinski@swmansion.com" Date: Mon, 3 Mar 2025 17:20:21 +0100 Subject: [PATCH] Refactor live render attrs --- example_project/lib/example_project_web/live/echo.ex | 4 ++-- lib/membrane_webrtc_live/capture.ex | 4 ++-- lib/membrane_webrtc_live/player.ex | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/example_project/lib/example_project_web/live/echo.ex b/example_project/lib/example_project_web/live/echo.ex index a622cc6..aae3c02 100644 --- a/example_project/lib/example_project_web/live/echo.ex +++ b/example_project/lib/example_project_web/live/echo.ex @@ -37,10 +37,10 @@ defmodule ExampleProjectWeb.Live.EchoLive do def render(assigns) do ~H"""

Captured stream preview

- +

Stream sent by the server

- + """ end end diff --git a/lib/membrane_webrtc_live/capture.ex b/lib/membrane_webrtc_live/capture.ex index 13dd75c..e80061c 100644 --- a/lib/membrane_webrtc_live/capture.ex +++ b/lib/membrane_webrtc_live/capture.ex @@ -61,7 +61,7 @@ defmodule Membrane.WebRTC.Live.Capture do attr(:socket, Phoenix.LiveView.Socket, required: true, doc: "Parent live view socket") - attr(:capture, :string, + attr(:capture_id, :string, required: true, doc: """ #{inspect(__MODULE__)} struct. It is used to pass capture id to the newly created live view via live view session. @@ -78,7 +78,7 @@ defmodule Membrane.WebRTC.Live.Capture do @spec live_render(map()) :: live_view when live_view: term() def live_render(assigns) do ~H""" - <%= live_render(@socket, __MODULE__, id: "#{@capture}-lv", session: %{"class" => @class, "id" => @capture}) %> + <%= live_render(@socket, __MODULE__, id: "#{@capture_id}-lv", session: %{"class" => @class, "id" => @capture_id}) %> """ end diff --git a/lib/membrane_webrtc_live/player.ex b/lib/membrane_webrtc_live/player.ex index b1a48e3..c793fe1 100644 --- a/lib/membrane_webrtc_live/player.ex +++ b/lib/membrane_webrtc_live/player.ex @@ -62,7 +62,7 @@ defmodule Membrane.WebRTC.Live.Player do attr(:socket, Phoenix.LiveView.Socket, required: true, doc: "Parent live view socket") - attr(:player, :string, + attr(:player_id, :string, required: true, doc: """ #{inspect(__MODULE__)} struct. It is used to pass player id to the newly created live view via live view session. @@ -79,7 +79,7 @@ defmodule Membrane.WebRTC.Live.Player do @spec live_render(map()) :: live_view when live_view: term() def live_render(assigns) do ~H""" - <%= live_render(@socket, __MODULE__, id: "#{@player}-lv", session: %{"class" => @class, "id" => @player}) %> + <%= live_render(@socket, __MODULE__, id: "#{@player_id}-lv", session: %{"class" => @class, "id" => @player_id}) %> """ end