WebRTC Components #1
Conversation
FelonEkonom
force-pushed
the
implement-webrtc-components
branch
from
ee595c4 to
7d2f4cc
Compare
FelonEkonom
requested review from
mat-hek and
kraleppa
and removed request for
mat-hek and
kraleppa
example_project/README.md
Outdated
There was a problem hiding this comment.
let's create a proper readme
- write what this example does
- mention which files are important
- remove the Phoenix links
- mention that this uses boombox
| ingress_signaling = Membrane.WebRTC.Signaling.new() | ||
| egress_signaling = Membrane.WebRTC.Signaling.new() | ||
|
|
||
| {:ok, _boombox_pid} = |
There was a problem hiding this comment.
this is actually a Task pid, not a boombox pid
| ~H""" | ||
| <Capture.live_render socket={@socket} capture={"mediaCapture"} /> | ||
| <Player.live_render socket={@socket} player={"videoPlayer"} /> | ||
| """ |
There was a problem hiding this comment.
It would be nice to have a preview here too, that would display the stream from the camera directly, without sending it through WebRTC. Maybe the Capture component could have an option to display the preview as well?
lib/boombox_live/webrtc/capture.ex
Outdated
There was a problem hiding this comment.
rename the directory to membrane_webrtc_live
lib/membrane_webrtc_live/capture.ex
Outdated
| # this is a hack to supress dialyzer, that for some reason thinks that `message` | ||
| # is a map, while it is a binary | ||
| message = | ||
| apply(__MODULE__, :identity, [message]) | ||
| |> Jason.decode!() |
There was a problem hiding this comment.
The reason is that the callback typing expects that the message is a map: https://hexdocs.pm/phoenix_live_view/Phoenix.LiveComponent.html#c:handle_event/3 Maybe it should be serialized and parsed automatically by LiveView?
No description provided.