Skip to content

fix bug where for local models, delete only the model passed in, not … #2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ethanova
Copy link

…all local models

Describe Your Changes

In Jan, I experienced a bug where I would import a model and all of a sudden, all of my other models were gone. I just did some digging finally and it appears that actually what was happening was that I previously deleted a local model, and that deleted all of my local models (all symbolic links). This should provide expected behavior of DeleteModel

Fixes Issues

  • I haven't created a bug, but I think this is the fix

Self Checklist

  • Added relevant comments, esp in complex areas
  • [?] Updated docs (for bug fixes / features)
  • [na] Created issues for follow-up changes or refactoring needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant