Skip to content

Fixes for meson format from stdin using editor config #14540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes for meson format from stdin using editor config #14540

wants to merge 2 commits into from

Conversation

bruchar1
Copy link
Member

@bruchar1 bruchar1 commented Apr 30, 2025 •
edited
Loading

Fixes #14423. Fixes #14538. Fixes #14539.

  • Fix parent paths recursion
  • Add argument for source file path when reading from stdin

bruchar1 added 2 commits April 30, 2025 15:13
@bruchar1
format: use absolute paths to find .editorconfig
9d44513 
Fixes mesonbuild#14538.

Resolve the source file path before searching .editorconfig files,
to ensure parents up to the root directory are visited.
@bruchar1
format: add --source-file-path argument for stdin
e704f56 
Fixes mesonbuild#14539.

Otherwise, .editorconfig is read from current working directory,
and there is no way to know what file name to filter to choose
the right section of editor config.
@bruchar1 bruchar1 requested a review from jpakkane as a code owner April 30, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpakkane jpakkane Awaiting requested review from jpakkane jpakkane is a code owner

Assignees
No one assigned
Labels
tool:format
Projects
None yet
Milestone
No milestone
1 participant
@bruchar1