vulkan: Find Vulkan libraries in non-standard locations #14557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amolenaar
force-pushed
the
vulkan-non-standard-path
branch
from
f893b2e to
bad0f56
Compare
amolenaar
changed the title
amolenaar
force-pushed
the
vulkan-non-standard-path
branch
from
bad0f56 to
000fab9
Compare
eli-schwartz
requested changes
May 4, 2025
VULKAN_SDK is the preferred environment variable to point to the Vulkan installation. With this change the old variable (VK_SDK_PATH) is made optional.
amolenaar
force-pushed
the
vulkan-non-standard-path
branch
from
000fab9 to
7e7d4ba
Compare
I separated the change in 2 smaller commit, and added a rationale for the change. |
amolenaar
force-pushed
the
vulkan-non-standard-path
branch
from
592fcaa to
7905244
Compare
eli-schwartz
requested changes
May 5, 2025
dcbaker
reviewed
May 5, 2025
This change ensures that Vulkan will be found in the path defined by the VULKAN_SDK env var. This is the case when the Vulkan SDK is not installed in a well-known location (/usr, /usr/local), but in a user's home folder.
Add test cases that target the Vulkan system dependeny resolver explicitly.
amolenaar
force-pushed
the
vulkan-non-standard-path
branch
3 times, most recently
from
9ad77d1 to
5f65c2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to make Vulkan work for GTK on macOS.
On macOS, the Vulkan SDK can be installed in a user's home folder. If not installed system-wide (e.i. in
/usr/local), Meson is not able to do a proper version check for Vulkan.Current behavior
The (obsolete) environment variable
VK_SDK_PATHhas to be set, or theVULKAN_SDKwill not be used at all.Vulkan version check fails, even if both
VK_SDK_PATHandVULKAN_SDKare set:New behavior
VULKAN_SDKcan be set withoutVK_SDK_PATHThe include path (based on
VULKAN_SDK) is now provided to the version-check command, sovulkan.hcan be found, and a version check can be done.