ref: replace if-else chain with dict lookup for response computation

[iw4p]

The new code won't waste time creating LLMs if none were specified, and can raise a ValueError right away.

[facebook-github-bot]

Hi @iw4p!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[SimonWan]

This change does not serve exactly the same purpose because we check llms_under_test in addition to args.llm_under_test.
It would be appropriate to extend the if condition to check both.

If you decide to update the commit, please also skip the middle commit in this chain, as it appears mergeable with this one. Thank you for your proposal!

[SimonWan]

Actually I also just published the change for this format, so you can skip both base commits and then focus on the if condition udpate.

[iw4p]

Hi SimonWan! Sure, I will ignore the black reformatting commits and just change the if statement. Thank you.

[iw4p]

Hey Simon! Both raise ValueErrors for materialized_llms_under_test and args.llm_under_test have been added. I ignored the black formatting commits too.

[SimonWan]

Please address my comments as the current version may still raise unexpected errors. Thank you.

[iw4p]

Please address my comments as the current version may still raise unexpected errors. Thank you.

Hi Simon! Thank you. I skipped the old commits and handled the error checking/controlling as you asked.

[SimonWan]

Thanks for the update! LGTM

[facebook-github-bot]

@SimonWan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@SimonWan merged this pull request in c3afa15.