Skip to content

Commit ad05979

Browse files
committed
fix: correct label htmlFor attribute in CBReviewModal and simplify MBIDMappingModal className
1 parent fb84a21 commit ad05979

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

Diff for: frontend/js/src/cb-review/CBReviewModal.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -566,7 +566,7 @@ export default NiceModal.create((props: CBReviewModalProps) => {
566566
className="form-check-input"
567567
required
568568
/>
569-
<label className="form-check-label" htmlFor="#acceptLicense">
569+
<label className="form-check-label" htmlFor="acceptLicense">
570570
<small>
571571
&nbsp;You acknowledge and agree that your contributed reviews to
572572
CritiqueBrainz are licensed under a Creative Commons

Diff for: frontend/js/src/common/listens/MBIDMappingModal.tsx

+1-2
Original file line numberDiff line numberDiff line change
@@ -159,8 +159,7 @@ export default NiceModal.create(({ listenToMap }: MBIDMappingModalProps) => {
159159
return (
160160
<>
161161
<div
162-
className={`modal fade ${visible ? "in" : ""}`}
163-
style={visible ? { display: "block" } : {}}
162+
className="modal fade"
164163
id="MBIDMappingModal"
165164
role="dialog"
166165
data-backdrop="true"

0 commit comments

Comments
 (0)