-
-
Notifications
You must be signed in to change notification settings - Fork 249
LB-1508 Allow hiding personal recommendations #2808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LB-1508 Allow hiding personal recommendations #2808
Conversation
Hello @Sumit1797! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-07-17 09:00:28 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Sorry for the delay. I just came across this PR. Can you please add tests for the feature as well?
Ping @Sumit1797 |
Hi I missed the requested changes, I will updated the PR. |
Adds the personal recs event type to the accepted event type enum for hiding events
@amCap1712 Note that I had to add a small change to the DB create_types SQL script which will be required to run when deploying |
@Sumit1797 Hope you don't mind, it seemed like life did its thing so I took over since there wasn't much left to do and I wanted to see this PR merged :) |
No problem, Sorry I couldn't spend more time on it, looking at your code it's a learning for me! |
add the personal_recording_recommendation enum value
if hidden in the database, make them hidden on the front-end as well by setting its `hidden` attribute to true
Finished and tested on test.listenbrainz.org, users can hide an event from front-end, then reloading the page shows the hidden event, then users can unhide the event and similarly after a refresh the event is unhidden. |
Problem
A user can hide recommendations received from another user but not personal recommendations.
(https://tickets.metabrainz.org/browse/LB-1508?filter=12410)
Solution
Add the ability to hide personal recommendations
Action
Change the backend api user_timeline_event_api to add an entry for personal recommendations in the hide_timeline_events table in database.