Skip to content

LB-1508 Allow hiding personal recommendations #2808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 17, 2024
Merged

LB-1508 Allow hiding personal recommendations #2808

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
904a4d8
LB-1508 bug fix
Sumit1797 Mar 12, 2024
8577e5c
pep 8 fix
Sumit1797 Mar 12, 2024
1a0a88a
indentation update
Sumit1797 Mar 12, 2024
4bde305
continuation line indetation
Sumit1797 Mar 12, 2024
49a7e1d
test
Sumit1797 Mar 12, 2024
392d1ea
indent
Sumit1797 Mar 12, 2024
4a812b9
Merge branch 'master' into LB-1508-allow-hiding-personal-recommendations
MonkeyDo Jun 10, 2024
bf78aae
Merge branch 'master' into pr/2808
MonkeyDo Jun 26, 2024
4bd2b27
SQL: allow hiding personal recommendation events
MonkeyDo Jun 26, 2024
69aab44
Feed: Add test for hiding personal recs events
MonkeyDo Jun 26, 2024
cef62c6
Add SQL update script
MonkeyDo Jul 17, 2024
bf73ec1
Set hidden personal recs events as hidden
MonkeyDo Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/js/src/user-feed/UserFeed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,7 @@ export default class UserFeedPage extends React.Component<
}
if (
(event.event_type === EventType.RECORDING_PIN ||
event.event_type === EventType.PERSONAL_RECORDING_RECOMMENDATION ||
event.event_type === EventType.RECORDING_RECOMMENDATION) &&
event.user_name !== currentUser.name
) {
Expand Down
4 changes: 3 additions & 1 deletion listenbrainz/webserver/views/user_timeline_event_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,9 @@ def hide_user_timeline_event(user_name):
raise APIBadRequest("JSON document must contain both event_type and event_id", data)

row_id = data["event_id"]
if data["event_type"] == UserTimelineEventType.RECORDING_RECOMMENDATION.value:
event_type = data["event_type"]
if event_type in [
UserTimelineEventType.RECORDING_RECOMMENDATION.value, UserTimelineEventType.PERSONAL_RECORDING_RECOMMENDATION.value]:
result = db_user_timeline_event.get_user_timeline_event_by_id(db_conn, row_id)
elif data["event_type"] == UserTimelineEventType.RECORDING_PIN.value:
result = get_pin_by_id(db_conn, row_id)
Expand Down