-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LB-1737: Create top artists graph showing album details #3170
LB-1737: Create top artists graph showing album details #3170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Graph looks good. Apart from the comments, can we change the color scheme of the graph to something using LB Color theme instead?
Also, it'll be great if we could also generate a similar graph for sitewide stats as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The graph looks awesome now🔥
I noticed a few improvements which can be made.
Co-authored-by: Ansh Goyal <anshg1214@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG!
The new artist activity widget is really cool! But I noticed a small issue with it, it seems that it used the artist name from the recording (listen?), and not the canonical artist name from MusicBrainz to group artists. Thus, I have the same artist twice with different names (one in Latin and one in Hangul). For what it's worth, my top artists list correctly lists that artist just once. |
@Maxr1998 Thanks for reporting the issue! Could I ask you to please open a new ticket in https://tickets.metabrainz.org/projects/LB with a screenshot of the stats? Could you also please check that your top artists for that time range (https://listenbrainz.org/user/Maxr1998/stats/top-artists) whos the same issue, maybe circling or describing the duplicate artist issue? |
Sure, opened a ticket as LB-1778. It appears to be specific to this new graph, though, since my top artists stats are correct. |
Problem
LB-1737: Create top artists graph showing album details
Solution
Using the previous data fetch
api
with some modifications and usingnivo.rocks
for the same to be displayed as a stacked/segmented bar graph.Action