LB-1657: Moved submitting-data page to setting

[Mshahnawaz1]

LB-1657: Submitting-data page need to be moved to setting section

Submitting-data page is currently in about page which is not intuitive for many users.
So moved submitting-data page to setting section.
The route for submitting-data is changed from /app-data to /setting/app-data.

Action

No action needed. Please verify this pull request.

[MonkeyDo]

Thanks for opening a PR!

I don't fully agree with the ticket as described, I think we should duplicate the access to that page, since the settings pages can only be accessed if logged in.
If a potential new user is looking at the website to get an idea of how it works, I think they should be able to access this page too.

So what you can do is leave the existing code as it was, and only add a link to the page in the settings page sub-menu layout (like you did here) , but instead of pointing to /add-data it should point to to: "../add-data/" as a relative path.

Hope it makes sense, don't hesitate if you have questions!

[Mshahnawaz1]

Thank you for your explanation.
So what I need to do is here is change to relative path ../add-data and import add-data from ("../../about/add-data/AddData").
Is this correct.

[MonkeyDo]

Thank you for your explanation. So what I need to do is here is change to relative path ../add-data and import add-data from ("../../about/add-data/AddData"). Is this correct.

The only change you need compared to master is adding { to: "../add-data/", label: "Submitting data" }, to the src/settings/layout.tsx file. That should be the only required change (adds a link to the add-data page in the settings sub-menu), all the rest can be reverted to be the same as the master branch.

[Mshahnawaz1]

I was making new routes making things more complicated, Thanks for explanation.
Here made the change and is working correctly.

But when using it , doesn't feel good UI as user goes from setting section to about section. won't it be good to keep it to either one of places. Please say you thoughts on it.

[MonkeyDo]

Well, I understand the worry, but as I explained above, all the settings routes require signing in.
I believe users should be able to view the page before they create an account.
So it cannot be only in the settings page.

On the other side, the ticket requests that we should more easily find the page in question for users who would be looking for it in the settings page where we have other tools to connect to your music services.
So it should be added in the settings page too.

I don't see another alternative than duplicating the link to it and having it in both places, unless you have another idea to propose.

[Mshahnawaz1]

Currently I don't find an alternative to this, for now we should go with the duplicates.

[MonkeyDo]

Looks good, thank you!

[Aerozol]

Thanks monkey - I didn't think about the whole settings sections being hidden when not logged in!