chore: Update Typescript to v5 #3240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From 4.9.3 to 5.8.2
Small changes after updating to TS v5 es5 > ES2018 target change so tat we can use named groups in regexps (in frontend/js/src/utils/utils.tsx) without triggering an error (was previously a warning)
Allows using ESM and CJS modules together, like we do with our webpack setup.
Issue with nivo packages, resolved by making sure we use the compiled and minified versions of D3 dependencies. See plouc/nivo#2310
Issues with typescript definitions, updating to latest version as it requires few changes and we now have working TS definitions.
MonkeyDo
added a commit
that referenced
this pull request
May 7, 2025
Getting some errors with ts-jest and the import style for tyhese components. Unfortunately this import style prevents tree-shaking I think, so should be reviewed once we have figured out our typescript setup with TS5 in #3240
The eslint-plugin-import package can't use the swiper module export style correctly. See import-js/eslint-plugin-import#1810
The folder structure changed.
|
After merging this, I will start working on removing the LESS compilation and dependencies, and moving everything to SASS instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes required to play well with newer dependencies, in particular the Swiper library.
TS 5.0 announcement blog: https://devblogs.microsoft.com/typescript/announcing-typescript-5-0-beta/#decorators
Note: When this is merged, the offscreencanvas types dependency added in #3225 should be removed.