Refactor dumps code #3278
Merged
Refactor dumps code #3278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only difference is format text vs csv.
Refactor the common dump setup code of setting up zstd compression, archive creation, temporary directory management and metadata writing into two context managers: `zstd_dump` and `uncompressed_dump`.
Replaced table dicts with a `DumpTable` model and a `DumpTablesCollection` class. This helps reduce redundancy in postgres + timescale dumps and mapping dumps.
Consolidate duplicate logic for PostgreSQL and TimescaleDB dumps into a single `dump_database` function that manages the creation of public and private dumps.
mayhem
approved these changes
May 19, 2025
|
|
||
| archive_name = 'musicbrainz-canonical-dump-{time}'.format( | ||
| time=dump_time.strftime('%Y%m%d-%H%M%S') | ||
| MAPPING_TABLES = [ |
|
|
||
| return escaped_table_name, joined_fields | ||
| PRIVATE_TABLES_TIMESCALE = DumpTablesCollection( |
There was a problem hiding this comment.
If could wish for one thing more that this table dumper could do, is to separate out public playlists from private playlists and put them into the dumps accordingly.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor dumps code for better readability and reducing redundancy. Individual commits explain the changes in more detail.