Hstaykov/refactor loops #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HristoStaykov
assigned zah, Dimo99, Owliie and Xearty and unassigned zah, Dimo99, Owliie and Xearty
Xearty
reviewed
Apr 22, 2024
vendor/zkllvm-metacraft-circuits/scripts/compile_and_run_tests.sh
Outdated
Show resolved
Hide resolved
Xearty
reviewed
Apr 22, 2024
vendor/zkllvm-metacraft-circuits/src/circuit_utils/base_types.h
Outdated
Show resolved
Hide resolved
Xearty
reviewed
Apr 22, 2024
Xearty
reviewed
Apr 22, 2024
vendor/zkllvm-metacraft-circuits/src/circuit_utils/base_types.h
Outdated
Show resolved
Hide resolved
Xearty
reviewed
Apr 22, 2024
vendor/zkllvm-metacraft-circuits/src/circuit_utils/circuit_byte_utils.h
Outdated
Show resolved
Hide resolved
Xearty
reviewed
Apr 22, 2024
vendor/zkllvm-metacraft-circuits/src/circuits_impl/verify_attestation_data_impl.h
Outdated
Show resolved
Hide resolved
Xearty
reviewed
Apr 22, 2024
vendor/zkllvm-metacraft-circuits/src/circuits_impl/verify_attestation_data_impl.h
Outdated
Show resolved
Hide resolved
Xearty
reviewed
Apr 22, 2024
vendor/zkllvm-metacraft-circuits/src/circuits_impl/verify_attestation_data_impl.h
Outdated
Show resolved
Hide resolved
Xearty
reviewed
Apr 22, 2024
vendor/zkllvm-metacraft-circuits/src/circuits_impl/verify_attestation_data_impl.h
Outdated
Show resolved
Hide resolved
Xearty
reviewed
Apr 22, 2024
Xearty
reviewed
Apr 22, 2024
Xearty
reviewed
Apr 22, 2024
Xearty
reviewed
Apr 22, 2024
Xearty
reviewed
Apr 23, 2024
vendor/zkllvm-metacraft-circuits/src/circuits_impl/verify_attestation_data_impl.h
Outdated
Show resolved
Hide resolved
Xearty
approved these changes
Apr 24, 2024
Dimo99
approved these changes
Apr 24, 2024
HristoStaykov
force-pushed
the
hstaykov/refactor_loops
branch
2 times, most recently
from
699ad1b to
a09b100
Compare
…ds, add documentation Added documentation for compute_shuffled_index. Added correct json input for compute_shuffled_index circuit in example. Clone test input data if needed. Added docs for verify_attestation_data_and_proof_finality and weigh_justification_and_finalization. All "loop unrolled" warnings fixed.
HristoStaykov
force-pushed
the
hstaykov/refactor_loops
branch
from
a09b100 to
0252168
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the latest version 17.0.4 of clang-zkllvm loops need to be bound by compile time constants. This PR introduces the necessary changes in order to follow this rule.