Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move the stdio ignoring code to the correct function: the incorrect fix was regressing ct generally #8

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

alehander92
Copy link
Contributor

i applied the original fix in a wrong way yesterday, which was leading to an exception whenever running readProcessOutput, as it does use the stdio

…ect fix was regression `ct` generally

i applied the fix in a wrong way yesterday, which was leading to an exception
whenever running `readProcessOutput`, as it does use the stdio
@cla-bot cla-bot bot added the cla-signed label Feb 26, 2025
@alehander92 alehander92 requested a review from pxor February 26, 2025 11:38
@alehander92 alehander92 self-assigned this Feb 26, 2025
@alehander92 alehander92 changed the title fix: move the stdio ignoring code to the correct function: the incorrect fix was regression ct generally fix: move the stdio ignoring code to the correct function: the incorrect fix was regressing ct generally Feb 26, 2025
@pxor pxor merged commit ce23eb2 into main Feb 26, 2025
13 checks passed
@pxor pxor deleted the fix-process-starting-regression branch February 26, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants