Skip to content

Commit

Permalink
feat(nimbus): Upgrade 24.12.0 -> 25.1.0
Browse files Browse the repository at this point in the history
Remove the `nimble.nix` patch as on version 25.1.0 there is no need to
patch `nimble.nix` as it contains the correct hash. I verified it like
this:

```
nurl -S https://github.com/nim-lang/nimble 123f97a5e4ee9ba35720c0869e19a047c43c797e
$ nix flake prefetch --extra-experimental-features 'nix-command flakes' --json git+https://github.com/nim-lang/nimble?allRefs=1&rev=123f97a5e4ee9ba35720c0869e19a047c43c797e&submodules=1
fetchFromGitHub {
  owner = "nim-lang";
  repo = "nimble";
  rev = "123f97a5e4ee9ba35720c0869e19a047c43c797e";
  hash = "sha256-Rz48sGUKZEAp+UySla+MlsOfsERekuGKw69Tm11fDz8=";
  fetchSubmodules = true;
}
```

The hash `sha256-Rz48sGUKZEAp+UySla+MlsOfsERekuGKw69Tm11fDz8=` is
exactly the same as the one in nimble.nix @ 25.1.0:
https://github.com/status-im/nimbus-eth2/blob/v25.1.0/nix/nimble.nix#L12
  • Loading branch information
galin-s authored and PetarKirov committed Feb 4, 2025
1 parent 29acf09 commit 2b631da
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 22 deletions.
18 changes: 7 additions & 11 deletions pkgs/nimbus/default.nix
Original file line number Diff line number Diff line change
@@ -1,20 +1,16 @@
{
applyPatches,
fetchFromGitHub,
pkgs,
targets ? ["nimbus_beacon_node" "nimbus_validator_client" "gnosis-build" "gnosis-vc-build"],
stableSystems ? ["x86_64-linux" "aarch64-linux"],
}: let
version = "24.12.0";
src = applyPatches {
src = fetchFromGitHub {
owner = "status-im";
repo = "nimbus-eth2";
rev = "v${version}";
hash = "sha256-DBvsnGr91a69eCj1hAeoVOpxas5rfaT36rIxWEmvIVg=";
fetchSubmodules = true;
};
patches = [./fix-hash.patch];
version = "25.1.0";
src = fetchFromGitHub {
owner = "status-im";
repo = "nimbus-eth2";
rev = "v${version}";
hash = "sha256-I+rDkVUk5BLxV2wNnRMHSE9Uuz9KykbVeXB40zvRZz8=";
fetchSubmodules = true;
};
in
import "${src}/nix" {inherit pkgs targets stableSystems;}
11 changes: 0 additions & 11 deletions pkgs/nimbus/fix-hash.patch

This file was deleted.

0 comments on commit 2b631da

Please sign in to comment.