Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt e2e tests to account for Ironic deployed by IrSO #2112

Closed
dtantsur opened this issue Nov 27, 2024 · 3 comments · Fixed by #2203
Closed

Adapt e2e tests to account for Ironic deployed by IrSO #2112

dtantsur opened this issue Nov 27, 2024 · 3 comments · Fixed by #2203
Assignees
@dtantsur
Labels
kind/ci Categorizes issue or PR as related to CI or testing. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@dtantsur
Copy link
Member

Currently, the tests assume that Ironic is either started locally or is deployed by BMO's deploy.sh. When deployed by IrSO, it looks differently, so at least re-pivoting tests fail.

/kind ci
/help
@metal3-io-bot metal3-io-bot added kind/ci Categorizes issue or PR as related to CI or testing. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Nov 27, 2024
@tuminoid tuminoid mentioned this issue Nov 27, 2024
Open
@tuminoid
Copy link
Member

tuminoid commented Nov 27, 2024 •
edited
Loading

We also need some keywords to run tests with IRSO. Created metal3-io/project-infra#920 in project infra for that.

@dtantsur
Copy link
Member Author

dtantsur commented Dec 4, 2024

/triage accepted

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Dec 4, 2024
@dtantsur
Copy link
Member Author

/remove-help
/assign

@metal3-io-bot metal3-io-bot removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Dec 30, 2024
@dtantsur dtantsur mentioned this issue Dec 30, 2024
Merged
dtantsur added a commit to dtantsur/cluster-api-provider-metal3 that referenced this issue Dec 30, 2024
@dtantsur
e2e: account for ironic-standalone-operator in pivoting tests
b136924 
BMO's deploy.sh is still used after pivoting. This should be addressed
separately.

Fixes: metal3-io#2112
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
dtantsur added a commit to dtantsur/cluster-api-provider-metal3 that referenced this issue Dec 30, 2024
@dtantsur
e2e: account for ironic-standalone-operator in pivoting tests
825120b 
BMO's deploy.sh is still used after pivoting. This should be addressed
separately.

Fixes: metal3-io#2112
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
dtantsur added a commit to dtantsur/cluster-api-provider-metal3 that referenced this issue Dec 31, 2024
@dtantsur
e2e: account for ironic-standalone-operator in pivoting tests
95efb4c 
BMO's deploy.sh is still used after pivoting. This should be addressed
separately.

Fixes: metal3-io#2112
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
dtantsur added a commit to dtantsur/cluster-api-provider-metal3 that referenced this issue Dec 31, 2024
@dtantsur
e2e: account for ironic-standalone-operator in pivoting tests
0f535d5 
BMO's deploy.sh is still used after pivoting. This should be addressed
separately.

Fixes: metal3-io#2112
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
dtantsur added a commit to dtantsur/cluster-api-provider-metal3 that referenced this issue Jan 2, 2025
@dtantsur
e2e: account for ironic-standalone-operator in pivoting tests
36cdc24 
BMO's deploy.sh is still used after pivoting. This should be addressed
separately.

Fixes: metal3-io#2112
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
dtantsur added a commit to dtantsur/cluster-api-provider-metal3 that referenced this issue Jan 8, 2025
@dtantsur
e2e: account for ironic-standalone-operator in pivoting tests
538a546 
BMO's deploy.sh is still used after pivoting. This should be addressed
separately.

Fixes: metal3-io#2112
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtantsur dtantsur

Labels
kind/ci Categorizes issue or PR as related to CI or testing. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
3 participants
@dtantsur @tuminoid @metal3-io-bot