Add async utils: callbackify, promisify, debounce, throttle #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshemsedinov
requested changes
Jan 22, 2025
Comment on lines
+67
to
73
| return () => { | ||
| if (timer) clearTimeout(timer); | ||
| timer = setTimeout(debounced, timeout); | ||
| timer = setTimeout(() => { | ||
| fn(...args); | ||
| timer = null; | ||
| }, delay); | ||
| }; |
There was a problem hiding this comment.
Use named functions as in prev implementation, it is much more readable than unnamed arrows
Comment on lines
+83
to
+85
| asyncFn(...args) | ||
| .then((res) => callback(null, res)) | ||
| .catch((err) => callback(err)); |
There was a problem hiding this comment.
Suggested change
| asyncFn(...args) | |
| .then((res) => callback(null, res)) | |
| .catch((err) => callback(err)); | |
| fn(...args) | |
| .then((res) => void callback(null, res), (err) => void callback(err)); |
| }; | ||
|
|
||
| const callbackify = | ||
| (fn) => | ||
| (asyncFn) => |
Comment on lines
+80
to
+82
| if (typeof callback !== 'function' || callback.length !== 2) { | ||
| throw new Error('Last argument should be a function with 2 parameters'); | ||
| } |
There was a problem hiding this comment.
We do not need such a check, callback may handle just first argument error and will be thrown while it is ok
|
FYI: Typings for callbacks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run test,npm run lint)npm run fix)Fixes #268