Configuration performance improvements

.github/workflows/build.yml

@@ -37,12 +37,12 @@ jobs:
       - name: Move to Checkout Path
         run: |
           mkdir -p /_/_work/${{ github.repository }}/${{ github.sha }}
-          mv * /_/_work/${{ github.repository }}/${{ github.sha }}
+          (shopt -s dotglob; mv * /_/_work/${{ github.repository }}/${{ github.sha }})
 
       - name: Setup .NET 6
         uses: actions/setup-dotnet@v3
         with:
-          dotnet-version: 6.0.x
+          dotnet-version: 8.0.x
 
       # Build
       - name: Restore NuGet Packages

src/Directory.Build.props

@@ -10,15 +10,38 @@
     <Configurations>debug;release</Configurations>
   </PropertyGroup>
 
+  <Target Name="AddGitMetadaAssemblyAttributes"
+    BeforeTargets="GetAssemblyAttributes">
+
+    <!--Executes
+    the Git Commands to get the Hash and Branch-->
+    <Exec Command="git rev-parse HEAD" ConsoleToMSBuild="true"
+      StandardOutputImportance="low" IgnoreExitCode="true" Condition=" '$(CommitHash)' == '' " WorkingDirectory="$(SolutionDir)">
+      <Output TaskParameter="ConsoleOutput" PropertyName="CommitHash" />
+    </Exec>
+    <Exec Command="git rev-parse --short HEAD" ConsoleToMSBuild="true"
+      StandardOutputImportance="low" IgnoreExitCode="true" Condition=" '$(CommitShortHash)' == '' "  WorkingDirectory="$(SolutionDir)">
+      <Output TaskParameter="ConsoleOutput" PropertyName="CommitShortHash" />
+    </Exec>
+    <Exec Command="git rev-parse --abbrev-ref HEAD" ConsoleToMSBuild="true"
+      StandardOutputImportance="low" IgnoreExitCode="true" Condition=" '$(CommitBranch)' == '' "  WorkingDirectory="$(SolutionDir)">
+      <Output TaskParameter="ConsoleOutput" PropertyName="CommitBranch" />
+    </Exec>
+
+    <ItemGroup>
+      <AssemblyMetadata Include="BuildTimestamp" Value="$([System.DateTime]::UtcNow.ToString(yyyy-MM-ddTHH:mm:ssK))" />
+      <AssemblyMetadata Condition=" $(CommitHash) != '' " Include="GitHash" Value="$(CommitHash)" />
+      <AssemblyMetadata Condition=" $(CommitBranch) != '' " Include="GitBranch" Value="$(CommitBranch)" />
+    </ItemGroup>
+  </Target>
+
   <PropertyGroup Label="PackageMetadata">
     <Company>MFDLABS</Company>
     <Copyright>Copyright © $(Company) $([System.DateTime]::Now.ToString(`yyyy`)). All rights reserved.</Copyright>
     <Authors>$(Company);Nikita Petko</Authors>
 
     <RepositoryUrl>https://github.com/mfdlabs/grid-bot-libraries</RepositoryUrl>
     <RepositoryType>git</RepositoryType>
-
-    <VersionPrefix>1.0.4</VersionPrefix>
   </PropertyGroup>
 
   <PropertyGroup Label="TestsProperties" Condition="$(MSBuildProjectName.Contains('.Tests'))">
@@ -59,4 +82,4 @@
   <ItemGroup>
     <None Include="README.md" Pack="true" PackagePath="" />
   </ItemGroup>
-</Project>
+</Project>

src/clients/client-settings-client/ClientSettings.Client.csproj

@@ -1,6 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <Description>HTTP client used to interact with Roblox's Client Settings API Site.</Description>
+
+    <Version>1.0.4</Version>
   </PropertyGroup>
 
   <ItemGroup>

src/clients/thumbnails-client/Thumbnails.Client.csproj

@@ -1,6 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <Description>HTTP client used to interact with Roblox's Thumbnails API Site.</Description>
+
+    <Version>1.0.4</Version>
   </PropertyGroup>
 
   <ItemGroup>

src/clients/users-client/Users.Client.csproj

@@ -1,6 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <Description>HTTP client used to interact with Roblox's Users API Site.</Description>
+
+    <Version>1.0.4</Version>
   </PropertyGroup>
 
   <ItemGroup>

src/configuration/configuration/Configuration.csproj

@@ -1,6 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <Description>C# adaptation for @mfdlabs/environment.</Description>
+
+    <Version>1.0.5</Version>
   </PropertyGroup>
 
   <ItemGroup>

src/configuration/configuration/Implementation/VaultProvider.cs

@@ -34,10 +34,10 @@ private static TimeSpan _defaultRefreshInterval
         }
     }
 
-    private static readonly string[] _propertyNamesIgnoredForApplyCurrent = new[]
+    private static readonly HashSet<string> _propertyNamesIgnored = new()
     {
         nameof(Mount),
-        nameof(Path)
+        nameof(Path),
     };
 
     private static readonly ConcurrentBag<VaultProvider> _providers = new();
@@ -83,7 +83,7 @@ protected override void SetRawValue<T>(string variable, T value)
     {
         if (_client == null) return;
 
-        _logger?.Debug("Set value in vault at path '{0}/{1}/{2}'", Mount, Path, variable);
+        _logger?.Debug("VaultProvider: Set value in vault at path '{0}/{1}/{2}'", Mount, Path, variable);
 
         var realValue = value.ToString();
 
@@ -103,7 +103,7 @@ public void ApplyCurrent()
         // Build the current from the getters.
         var values = GetLatestValues();
 
-        _logger?.Debug("Writing secret '{0}/{1}' to Vault!", Mount, Path);
+        _logger?.Debug("VaultProvider: Writing secret '{0}/{1}' to Vault!", Mount, Path);
 
         _client?.V1.Secrets.KeyValue.V2.WriteSecretAsync(
             mountPoint: Mount,
@@ -121,7 +121,7 @@ private Dictionary<string, object> GetLatestValues()
     {
         var getters = GetType()
             .GetProperties(BindingFlags.Public | BindingFlags.Instance)
-            .Where(prop => !_propertyNamesIgnoredForApplyCurrent.Contains(prop.Name));
+            .Where(prop => !_propertyNamesIgnored.Contains(prop.Name));
 
         var newCachedValues = new Dictionary<string, object>();
 
@@ -131,7 +131,7 @@ private Dictionary<string, object> GetLatestValues()
 
             try
             {
-                _logger?.Debug("Fetching initial value for {0}.{1}", GetType().Name, getterName);
+                _logger?.Debug("VaultProvider: Fetching initial value for {0}.{1}", GetType().Name, getterName);
 
                 var value = getter.GetGetMethod().Invoke(this, Array.Empty<object>());
                 var realValue = value?.ToString() ?? string.Empty;
@@ -143,7 +143,7 @@ private Dictionary<string, object> GetLatestValues()
             }
             catch (TargetInvocationException ex)
             {
-                _logger?.Warning("Error occurred when fetching getter for '{0}.{1}': {2}", GetType().Name, getterName, ex.InnerException.Message);
+                _logger?.Debug("VaultProvider: Error occurred when fetching getter for '{0}.{1}': {2}", GetType().Name, getterName, ex.InnerException.Message);
 
                 newCachedValues.Add(getterName, string.Empty);
             }
@@ -159,7 +159,7 @@ private Dictionary<string, object> GetLatestValues()
     protected VaultProvider(ILogger logger = null)
     {
         logger ??= Logger.Singleton;
-        
+
         SetLogger(logger);
 
         _logger?.Debug("VaultProvider: Setup for '{0}/{1}' to refresh every '{2}' interval!", Mount, Path, RefreshInterval);
@@ -186,7 +186,7 @@ private static void RefreshThread()
                     _staticLogger?.Error(ex);
                 }
             }
-            
+
             Thread.Sleep(RefreshInterval); // SetClient makes DoRefresh call.
         }
     }
@@ -214,7 +214,7 @@ private void DoRefresh()
         {
             if (ex.HttpStatusCode == HttpStatusCode.NotFound)
             {
-                _logger?.Warning("VaultProvider: DoRefresh for secret '{0}/{1}' failed: No secret found!", Mount, Path);
+                _logger?.Debug("VaultProvider: DoRefresh for secret '{0}/{1}' failed: No secret found!", Mount, Path);
 
                 return;
             }
@@ -225,15 +225,52 @@ private void DoRefresh()
         }
     }
 
+    private bool HasProperty(ref string name)
+    {
+        var type = GetType();
+        var getter = type.GetProperty(name, BindingFlags.Instance | BindingFlags.Public);
+
+        if (getter == null)
+        {
+            var propertyName = name;
+            var property = (from prop in type.GetProperties(BindingFlags.Instance | BindingFlags.Public)
+                            let attrib = prop.GetCustomAttribute<SettingNameAttribute>()
+                            where !_propertyNamesIgnored.Contains(prop.Name) && attrib?.Name == propertyName
+                            select prop).SingleOrDefault();
+
+            if (property == null)
+            {
+                _logger?.Debug("VaultProvider: Skipping property changed handler for '{0}' because settings provider '{1}' does not define it!", name, this);
+                _logger?.Warning("{0}: Unknown property '{1}', make sure it is defined in the settings provider or has a appropriate [{2}] attribute!", GetType().Name, name, nameof(SettingNameAttribute));
+
+                return false;
+            }
+
+            name = property.Name;
+        }
+
+        return true;
+    }
+
     private void InvokePropertyChangedForChangedValues(IDictionary<string, object> newValues)
     {
         if (_cachedValues.Count == 0)
         {
             foreach (var kvp in newValues)
             {
-                _logger?.Debug("Invoking property changed handler for '{0}'", kvp.Key);
+                if (_propertyNamesIgnored.Contains(kvp.Key))
+                {
+                    _logger?.Debug("VaultProvider: Skipping property changed handler for '{0}' as it is a reserved property!", kvp.Key);
+
+                    continue;
+                }
+
+                var propertyName = kvp.Key;
+                if (!HasProperty(ref propertyName)) continue;
 
-                PropertyChanged?.Invoke(this, new(kvp.Key));
+                _logger?.Debug("VaultProvider: Invoking property changed handler for '{0}'", propertyName);
+
+                PropertyChanged?.Invoke(this, new(propertyName));
             }
 
             return;
@@ -244,9 +281,19 @@ private void InvokePropertyChangedForChangedValues(IDictionary<string, object> n
             if (_cachedValues.TryGetValue(kvp.Key, out var value))
                 if (value.ToString().Equals(kvp.Value.ToString())) continue;
 
-            _logger?.Debug("Invoking property changed handler for '{0}'", kvp.Key);
+            if (_propertyNamesIgnored.Contains(kvp.Key))
+            {
+                _logger?.Debug("VaultProvider: Skipping property changed handler for '{0}' as it is a reserved property!", kvp.Key);
+
+                continue;
+            }
+
+            var propertyName = kvp.Key;
+            if (!HasProperty(ref propertyName)) continue;
+
+            _logger?.Debug("Invoking property changed handler for '{0}'", propertyName);
 
-            PropertyChanged?.Invoke(this, new(kvp.Key));
+            PropertyChanged?.Invoke(this, new(propertyName));
         }
     }
 
@@ -256,10 +303,11 @@ private void InvokePropertyChangedForChangedValues(IDictionary<string, object> n
     /// <inheritdoc cref="BaseProvider.GetRawValue(string, out string)"/>
     protected override bool GetRawValue(string key, out string value)
     {
-        value = null;
+        object v;
 
-        if (!_cachedValues.TryGetValue(key, out var v)) 
-            return base.GetRawValue(key, out value);
+        lock (_cachedValues)
+            if (!_cachedValues.TryGetValue(key, out v))
+                return base.GetRawValue(key, out value);
 
         if (v is JsonElement element)
             value = element.GetString();
@@ -268,4 +316,4 @@ protected override bool GetRawValue(string key, out string value)
 
         return true;
     }
-}
+}

src/configuration/core/Configuration.Core.csproj

@@ -1,6 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <Description>Helpers for configuration in applications.</Description>
+
+    <Version>1.0.4</Version>
   </PropertyGroup>
 
   <ItemGroup>

src/file-system/file-system/FileSystem.csproj

@@ -1,6 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <Description>File system helpers and more!</Description>
+
+    <Version>1.0.4</Version>
   </PropertyGroup>
 
   <ItemGroup>

src/floodcheckers/core/FloodCheckers.Core.csproj

@@ -1,6 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <Description>Core library for flood checker implementation!</Description>
+
+    <Version>1.0.4</Version>
   </PropertyGroup>
 
   <ItemGroup>

src/floodcheckers/redis/FloodCheckers.Redis.csproj

@@ -1,6 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <Description>Library for interacting with Redis based flood checkers!</Description>
+
+    <Version>1.0.4</Version>
   </PropertyGroup>
 
   <ItemGroup>

src/grid/client/Grid.Client.csproj

@@ -1,6 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <Description>SOAP library shared by grid-server processes!</Description>
+
+    <Version>1.0.4</Version>
   </PropertyGroup>
 
   <ItemGroup>

src/grid/commands/Grid.Commands.csproj

@@ -1,6 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <Description>Shared library containing models used by grid-servers for specific script execution actions.</Description>
+
+    <Version>1.0.4</Version>
   </PropertyGroup>
 
   <!-- Embed all Scripts/*.lua files into the assembly -->

src/grid/port-management/Grid.PortManagement.csproj

@@ -2,6 +2,7 @@
   <PropertyGroup>
     <Description>Shared library for port allocation on grid-servers!</Description>
 
+    <Version>1.0.4</Version>
     <RootNamespace>Grid</RootNamespace>
   </PropertyGroup>
 

src/grid/process-management-core/Grid.ProcessManagement.Core.csproj

@@ -2,6 +2,7 @@
   <PropertyGroup>
     <Description>Shared library for core interaction with grid server processes!</Description>
 
+    <Version>1.0.4</Version>
     <RootNamespace>Grid</RootNamespace>
   </PropertyGroup>
 

src/grid/process-management-docker/Grid.ProcessManagement.Docker.csproj

@@ -2,6 +2,7 @@
   <PropertyGroup>
     <Description>Shared library for interaction with Docker based grid server processes!</Description>
 
+    <Version>1.0.4</Version>
     <RootNamespace>Grid</RootNamespace>
   </PropertyGroup>
 

src/grid/process-management/Grid.ProcessManagement.csproj

@@ -2,6 +2,7 @@
   <PropertyGroup>
     <Description>Shared library for allocating grid-server processes!</Description>
 
+    <Version>1.0.4</Version>
     <RootNamespace>Grid</RootNamespace>
   </PropertyGroup>
 

src/hashing/hashing/Hashing.csproj

@@ -1,5 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <Description>Shared library to help with hashing.</Description>
+
+    <Version>1.0.4</Version>
   </PropertyGroup>
 </Project>

src/logging/logging/Logging.csproj

@@ -1,6 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <Description>Shared logging library!</Description>
+
+    <Version>1.0.4</Version>
   </PropertyGroup>
 
   <PropertyGroup>

src/networking/networking/Networking.csproj

@@ -1,6 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <Description>Library used for IP address parsing and more!</Description>
+
+    <Version>1.0.4</Version>
   </PropertyGroup>
 
   <ItemGroup>