Configuration sync disposable config providers #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All packages are now on inline versioning.
~ Convert LogLevel property into a getter for dynamic runtime fetching of the log level. ~ Add a fix on Windows for color logging failing by manually updating the console mode flags with ENABLE_VIRTUAL_TERMINAL_PROCESSING. ~ Rename LogLevel.Trace and ILogger.Trace to Verbose and add better docomments to each method and log level to better explain their use cases. ~ Remove ILogger.Log as this was technically an alias to ILogger.Information as it did the same thing. ~ Update all log methods to now take the raw message getter instead of formatting the messages themselves, this will help to introduce better performance by not evaluating the message straight away. ~ Add another ILogger.Error method with an argument to supply a message that precedes the exception trace back.
Convert IVaultProvider to IDisposable Update current registered auto refresh providers to a dictionary to make concurrent removal easier. Expose the current cached values to inheritied classes. Convert mount and path to virutal to not introduce a breaking change by adding set to the mix. Move the refresh thread from a simple thread wait to a wait event system to allow manual refreshing of all global providers. Add argument to constructors to control if the provider should be added to the auto refresh thread or not. Add extra constructor to allow setting mount and path via constructor. Implement IDisposable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.