Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added icons from svg #844

Merged
merged 2 commits into from
Feb 20, 2025
Merged

feat(icons): added icons from svg #844

merged 2 commits into from
Feb 20, 2025

Conversation

guidozoli
Copy link
Contributor

Description

Added icons from svg

image

[IMPORTANT] PR Checklist

  • I am aware of standards and conventions adopted in this repository, defined in the CONTRIBUTING.md file

PR conventions

Please make sure your PR complies with the following rules before submitting it.

  • PR title follows the <type>(<scope>): <subject> structure

  • The PR has been labeled according to the type of changes (e.g. enhancement, new component, bug).

    NOTE
    Some labels are used to generate release note entries: you can find the complete mapping between PR labels and release note categories here.
    For a more detailed overview of PR labels, please refer to the dedicated CONTRIBUTING section.

Additional code checks

Based on your changes, some of these checks may not apply. Please make sure to check the relevant items in the list.

  • Changes are covered by tests
  • Changes to components are accessible and documented in the Storybook
  • Typings have been updated
  • New components are exported from the src/index.ts file
  • New files include the Apache 2.0 License disclaimer
  • The browser console does not contain errors

@guidozoli guidozoli added the Icon component Icon component and hooks related activities label Feb 20, 2025
@guidozoli guidozoli requested a review from a team as a code owner February 20, 2025 14:45
fredmaggiowski
fredmaggiowski previously approved these changes Feb 20, 2025
Copy link
Member

@fredmaggiowski fredmaggiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fredmaggiowski fredmaggiowski self-requested a review February 20, 2025 15:11
@fredmaggiowski fredmaggiowski merged commit 1d2cb07 into main Feb 20, 2025
6 checks passed
@fredmaggiowski fredmaggiowski deleted the feat/added-icons branch February 20, 2025 16:55
@fredmaggiowski fredmaggiowski added the enhancement New feature or request label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Icon component Icon component and hooks related activities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants