auto get modality #567
Open
auto get modality #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the get_modality function to automatically detect content type (text, image, or audio) based on input patterns rather than requiring explicit modality specification.
- Modified
get_modalityinlibs/infinity_emb/infinity_emb/fastapi_schemas/pymodels.pyto examine URL patterns, file extensions, and data URI prefixes - Added pattern recognition for common image formats (jpg, jpeg, png, etc.) and audio formats (mp3, wav, etc.)
- Implemented fallback to explicit modality parameter when available
- Improved user experience by reducing the need for manual modality specification
- This change supports the integration of models like nomic-ai/nomic-embed-text-v1.5 mentioned in issue Support for nomic-ai/nomic-embed-text-v1.5 #123
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
1 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Checklist
Additional Notes
Add any other context about the PR here.