Skip to content

Commit

Permalink
Added minHeight to profiler flamegraphs (elastic#210443)
Browse files Browse the repository at this point in the history
## Summary
Solves elastic/prodfiler#4896

This PR set a minimum height of 400px to flamegraph charts in universal
profiling.

below shows the flamegraphs at their minimum heights.

<img width="860" alt="Screenshot 2025-02-10 at 10 24 02"
src="https://github.com/user-attachments/assets/ad121d44-da47-46a5-a719-08b59fee74c4"
/>
<img width="1040" alt="Screenshot 2025-02-10 at 10 24 22"
src="https://github.com/user-attachments/assets/feb07704-74a1-4eab-ab29-0bac59944296"
/>

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
  • Loading branch information
bryce-b authored Feb 20, 2025
1 parent 0fb26ea commit ad9baa6
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export function FlameGraph({
<EuiFlexItem>
<EuiFlexGroup direction="row">
{columnarData.viewModel.label.length > 0 && (
<EuiFlexItem grow>
<EuiFlexItem grow style={{ minHeight: '400px' }}>
<Chart key={columnarData.key}>
<Settings
theme={chartTheme}
Expand Down

0 comments on commit ad9baa6

Please sign in to comment.