Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to the npm registry not GHP #10

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

microbit-matt-hillsdon
Copy link
Contributor

@microbit-matt-hillsdon microbit-matt-hillsdon commented Sep 24, 2024

This will enable easy consumption from the open source ML tool app.

I'll release a 0.4.1 after this is merged. There are no other recent changes so it'll be just the header generator and a pointless version of the extension (not an issue, just noting).

This will enable easy consumption from the open source ML tool app.
@@ -4,12 +4,14 @@ on:
release:
types: [created]
push:
branches: '*'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VS code flagged this syntax as invalid for me. Though I suspect it may work fine it doesn't seem worth arguing!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! I think I've used the same syntax in other workflow files, I'll keep it in mind the next time I'll update them 👍

Copy link
Collaborator

@microbit-carlos microbit-carlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tried a dry push to npm, but changes look good 👍

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit 6e77b02 into main Sep 24, 2024
4 checks passed
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the ghp-to-npm branch September 24, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants