RecoveryInterceptor throw exception for bad request #7558
Answered
by
dstepanov
o-shevchenko
asked this question in
Q&A
-
|
I'm trying to use Micronaut with Reactor but I faced problems with returning errors.
I'm trying to do something like this: @Post(uri = "/test")
fun test(
@Body dto: Dto
): Publisher<HttpResponse<Unit>> {
return Mono.from(service.test(dto))
.map { HttpResponse.ok(it) }
.defaultIfEmpty(HttpResponse.notFound())
.onErrorResume(TestException::class.java) { exception ->
Mono.just(HttpResponse.badRequest(JsonError(exception.message)))
}
}And call it by Micronaut declarative client: @Client
@CircuitBreaker
@Headers(Header(name = ACCEPT, value = "application/json"))
interface MyClient {
@Post("/test")
fun test(
@Body dto: Dto
):HttpResponse<Any>
}But in this case, RecoveryInterceptor still throws an exception instead of returning just BAD_REQUEST. If I use OK, Miccronaut returns status correctly: but not for BadRequest Am I doing something wrong? Is it a bug? |
Beta Was this translation helpful? Give feedback.
Answered by
dstepanov
Jun 8, 2022
Replies: 2 comments 8 replies
-
|
Looks like it happens here: https://github.com/micronaut-projects/micronaut-core/blob/3.5.x/http-client/src/main/java/io/micronaut/http/client/netty/DefaultHttpClient.java#L3275 |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
According to the documentation https://docs.micronaut.io/latest/guide/#lowLevelClientError
It might be a good idea to have some option in |
Beta Was this translation helpful? Give feedback.
8 replies
-
|
as described in the issue i linked, changing this property would not actually help you. |
Beta Was this translation helpful? Give feedback.
-
|
I was returning just BadRequest using error handler, and it worked perfectly for me. But it doesn't work with Reactor. |
Beta Was this translation helpful? Give feedback.
-
|
There is no such option, I was only suggesting it. What is in your controller doesn't really matters. You should be able to do some switch-on-error and retrieve the body there. |
Beta Was this translation helpful? Give feedback.
-
|
ok, thanks for your replies |
Beta Was this translation helpful? Give feedback.
-
|
Just for the history, I opened related issue: #7575 |
Beta Was this translation helpful? Give feedback.
Answer selected by
o-shevchenko
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to the documentation https://docs.micronaut.io/latest/guide/#lowLevelClientError
It might be a good idea to have some option in
@Client(throwOnError = false)to allow receivingHttpResponsewhen status is >= 400. WDYT @graemerocher @yawkat