Grpc protobuff json support #1029
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will add tests shortly. got rid of javadoc nagging
… mapper could be a better implementation, but this one we replaced it with is the standard one that comes with google, so that's one less dependency leaving this implmentation to be pure micronaut and google.
… Saving to ask for assistance
creating a grpc service in groovy and cleaned up some check errors
…o get the controller to register when the system is starting. If we force the annotation scan this works, but we need to figure out how to automate that
…o get the controller to register when the system is starting. If we force the annotation scan this works, but we need to figure out how to automate that
…ted sample project for tutorial.
…r tests for all the classes.
Now if you annotate the grpc client you can get a client rest stub, too
…was the same logic to find these methods and invoke them, may as well do it for blocking services and async clients, too. Passes all the same tests successfully
…was the same logic to find these methods and invoke them, may as well do it for blocking services and async clients, too. Passes all the same tests successfully
|
I updated this to also support bean registration for grpc clients. Now if someone hands me a grpc service, the act of annotating that bean with @GrpcRestJsonExposed will allow the controller to register that bean for GRPC JSON serialization. Also added support for both async and blocking calls. I'm going to write a tutorial for these use cases.. but I think we're in pretty good shape as far as the use cases we test for this. I fell like it's fully featured now - I'll stop adding stuff to it now and see if you can review it. |
|
@graemerocher how's this look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gRPC JSON protocol buffer support
#1025 had a quick discussion on this, I found myself converting from JSON to Proto and back often - just so I can read the data a little easier. Since other debugging tools have built in serialization reading, and since a lot of data scientists I work with prefer JSON calls over gRPC.
Per discussion, this feature does the following:
For any grpc project in micronaut, if you annotate a service with @io.micronaut.grpc.annotation.GrpcRestJsonExposed then it will create endpoints based on the service definition and allow for a REST JSON endpoint to proxy grpc requests between JSON and gRPC.
This can be useful in testing situations or for exposing grpc services to front ends using basic HTTP1.1 communication.
This can also be used to quickly serialize between REST services or protocol buffer endpoints.
Finally, if you have this running, it's can be easier to test this via cURL.
This uses the google json parser and printer for the serialization.
Although the concept was simple, it required a lot of testing use cases, but let me know if I missed some use cases and I'll add more tests.
Additions