aioble/device.py: No default timeout for async disconnected() method. #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rknegjens
force-pushed
the
aioble-device-disconnected-default-timeout
branch
from
e06c032 to
0b7f49e
Compare
rknegjens
changed the title
disconnected() method.
rknegjens
force-pushed
the
aioble-device-disconnected-default-timeout
branch
from
0b7f49e to
924b5e5
Compare
|
This does make sense to me, I know a couple of other people this timeout has tripped up too. I'm not sure if there was a specific intention behind having a timeout here, can you comment @jimmo ? |
andrewleech
approved these changes
Apr 6, 2022
rknegjens
force-pushed
the
aioble-device-disconnected-default-timeout
branch
from
924b5e5 to
05e84b5
Compare
|
This also tripped me up and caused a lot of debug time... can this get merged? |
|
I agree, the default makes more sense as In fact, the temp sensor example was just changed to explicitly specify this: d4362d5 |
The value for the `timeout_ms` optional argument to `DeviceConnection.disconnected()` async method is changed from 60000 to None. This way users awaiting a device disconnection using `await connection.disconnected()` won't be surprised by a 1 minute timeout.
dpgeorge
force-pushed
the
aioble-device-disconnected-default-timeout
branch
from
05e84b5 to
db7f9a1
Compare
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value for the
timeout_msoptional argument toDeviceConnection.disconnected()async method is changed from 60000 to None. This way users awaiting a device disconnection usingawait connection.disconnected()won't be surprised by a 1 minute timeout. For instance, in thetemp_sensor.pyusage example I think it's reasonable to expect the connection to the client to stay open indefinitely.