From 2e6f58d141d2cb958449f1b76a19430bebe85020 Mon Sep 17 00:00:00 2001
From: Gabe Stocco <98900+gfs@users.noreply.github.com>
Date: Fri, 24 Apr 2020 08:03:39 -0700
Subject: [PATCH] Fixes GUI updates when collecting. (#401)
* Fix Gui Spinner issue.
---
Cli/Cli.csproj | 1 -
Cli/Controllers/HomeController.cs | 12 ++++++------
README.md | 6 +++++-
3 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/Cli/Cli.csproj b/Cli/Cli.csproj
index 5af035694..88e4a3a9a 100644
--- a/Cli/Cli.csproj
+++ b/Cli/Cli.csproj
@@ -67,7 +67,6 @@
all
runtime; build; native; contentfiles; analyzers; buildtransitive
-
diff --git a/Cli/Controllers/HomeController.cs b/Cli/Controllers/HomeController.cs
index c5aefc06c..5b632fa04 100644
--- a/Cli/Controllers/HomeController.cs
+++ b/Cli/Controllers/HomeController.cs
@@ -8,6 +8,7 @@
using AttackSurfaceAnalyzer.Utils;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc;
+using Newtonsoft.Json;
using System;
using System.Collections.Generic;
using System.Diagnostics;
@@ -15,7 +16,6 @@
using System.Linq;
using System.Threading.Tasks;
using System.Web;
-using Utf8Json;
namespace AttackSurfaceAnalyzer.Gui.Controllers
{
@@ -51,7 +51,7 @@ public ActionResult GetMonitorResults(string RunId, int Offset, int NumResults)
output["Requested"] = NumResults;
output["Actual"] = results.Count;
- return Json(JsonSerializer.Serialize(output));
+ return Json(JsonConvert.SerializeObject(output));
}
public ActionResult GetResults(string BaseId, string CompareId, int ResultType, int Offset, int NumResults)
@@ -65,7 +65,7 @@ public ActionResult GetResults(string BaseId, string CompareId, int ResultType,
output["Offset"] = Offset;
output["Requested"] = NumResults;
output["Actual"] = results.Count;
- return Json(JsonSerializer.Serialize(output));
+ return Json(JsonConvert.SerializeObject(output));
}
@@ -91,7 +91,7 @@ public ActionResult GetCollectors()
Dictionary output = new Dictionary();
output.Add("RunId", RunId);
output.Add("Runs", dict);
- return Json(JsonSerializer.Serialize(output));
+ return Json(JsonConvert.SerializeObject(output));
}
public ActionResult GetLatestRunId()
@@ -110,7 +110,7 @@ public ActionResult GetMonitorStatus()
}
//@TODO: Also return the RunId
- return Json(JsonSerializer.Serialize(dict));
+ return Json(JsonConvert.SerializeObject(dict));
}
public ActionResult GetComparators()
@@ -124,7 +124,7 @@ public ActionResult GetComparators()
}
//@TODO: Also return the RunId
- return Json(JsonSerializer.Serialize(dict));
+ return Json(JsonConvert.SerializeObject(dict));
}
diff --git a/README.md b/README.md
index a32d51757..8e2b89511 100644
--- a/README.md
+++ b/README.md
@@ -7,7 +7,11 @@ If you have .NET Core 3.1 installed you can install Attack Surface Analyzer with
Platform specific binaries for Attack Surface Analyzer are distributed via our GitHub [releases](https://github.com/Microsoft/AttackSurfaceAnalyzer/releases/latest) page.
## Note on Version
-The latest stable version of Attack Surface Analyzer is 2.1 (see [Release\v2.1](https://github.com/Microsoft/AttackSurfaceAnalyzer/tree/release/v2.1)). 2.2 is available in Beta.
+The latest stable version of Attack Surface Analyzer is 2.1 (see [Release\v2.1](https://github.com/Microsoft/AttackSurfaceAnalyzer/tree/release/v2.1)).
+
+2.2 is available in Beta.
+
+2.3 is now in development. You can see the features coming [here](https://github.com/microsoft/attacksurfaceanalyzer/issues?q=is%3Aissue+milestone%3Av2.3+).
## New Features in 2.2