Skip to content

Commit d1399a8

Browse files
fix: readme updated quota, python version recommendation, fabric deployment guide (#520)
* fix: update setup_env.sh to use sudo for script permissions and removed azure function tools; improve user email retrieval in create_sql_user_and_role.sh; clean up requirements * fix: update setup_env.sh to ensure execute permissions for quota_check_params.sh; adjust Deployment Guide token capacity recommendation and Python version range * update FabricDeployment.md * update FabricDeployment.md * update FabricDeployment.md * update parameter name for Azure deployment in CAdeploy.yml * updated the allowed regions for Azure OpenAI location and removed gpt-4o model * update quota_check.md to increase GPT-4o-mini token capacity and modify default regions in quota_check_params.sh --------- Co-authored-by: Abdul-Microsoft <v-amujeebta@microsoft.com>
1 parent 4a1e1b5 commit d1399a8

File tree

7 files changed

+13
-11
lines changed

7 files changed

+13
-11
lines changed

.devcontainer/setup_env.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ git pull
55

66
# provide execute permission to quotacheck script
77
sudo chmod +x ./infra/scripts/checkquota.sh
8+
sudo chmod +x ./infra/scripts/quota_check_params.sh
89

910
# Add the path to ~/.bashrc for persistence
1011
if ! grep -q '/opt/mssql-tools18/bin' ~/.bashrc; then

.github/workflows/CAdeploy.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ jobs:
115115
az deployment group create \
116116
--resource-group ${{ env.RESOURCE_GROUP_NAME }} \
117117
--template-file infra/main.bicep \
118-
--parameters AZURE_ENV_OPENAI_LOCATION=${{ env.AZURE_LOCATION }}
118+
--parameters AzureOpenAILocation=${{ env.AZURE_LOCATION }}
119119
120120
- name: List KeyVaults and Store in Array
121121
id: list_keyvaults

docs/DeploymentGuide.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Here are some example regions where the services are available: East US, East US
2424
### [Optional] Quota Recommendations
2525
By default, the **Gpt-4o-mini model capacity** in deployment is set to **30k tokens**, so we recommend
2626

27-
> **For Global Standard | GPT-4o-mini - the capacity to at least 100k tokens post-deployment for optimal performance.**
27+
> **For Global Standard | GPT-4o-mini - increase the capacity to at least 150k tokens post-deployment for optimal performance.**
2828
2929
To adjust quota settings, follow these [steps](AzureGPTQuotaSettings.md)
3030

@@ -80,7 +80,7 @@ If you're not using one of the above options for opening the project, then you'l
8080
1. Make sure the following tools are installed:
8181
- [PowerShell](https://learn.microsoft.com/en-us/powershell/scripting/install/installing-powershell?view=powershell-7.5) <small>(v7.0+)</small> - available for Windows, macOS, and Linux.
8282
- [Azure Developer CLI (azd)](https://aka.ms/install-azd)
83-
- [Python 3.9+](https://www.python.org/downloads/)
83+
- [Python 3.9 to 3.11](https://www.python.org/downloads/)
8484
- [Docker Desktop](https://www.docker.com/products/docker-desktop/)
8585
- [Git](https://git-scm.com/downloads)
8686
- [Microsoft ODBC Driver 18 for SQL Server](https://learn.microsoft.com/en-us/sql/connect/odbc/download-odbc-driver-for-sql-server?view=sql-server-ver16)

docs/FabricDeployment.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,17 +47,19 @@
4747
2. Select Fabric Workspace
4848
3. Click `Select`
4949
4. After publish is complete, navigate to Fabric Workspace
50-
5. Click `...` next to the Semantic model for Power BI report
50+
5. You will find the report in the Fabric Workspace under the name **WealthAdvisor-Client360Report**.
51+
6. Use the report's filtering options to analyze client data.
52+
<!-- 5. Click `...` next to the Semantic model for Power BI report
5153
6. Click on `Settings`
5254
7. Click on `Edit credentials` (under Data source credentials)
5355
8. Select `OAuth2` for the Authentication method
5456
9. Select option for `Privacy level setting for this data source`
5557
10. Click `Sign in`
5658
11. Navigate back to Fabric workspace and click on Power BI report.
5759
12. Click on `File` -> `Embed Report` -> `Website or Portal` from the top menu.
58-
13. Copy the first line from the popup with title `Here's a link you can use to embed this content.` for use later in step 5.6.
60+
13. Copy the first line from the popup with title `Here's a link you can use to embed this content.` for use later in step 5.6. -->
5961

60-
## Step 5: Update the Power BI URL in Azure App Service configuration
62+
<!-- ## Step 5: Update the Power BI URL in Azure App Service configuration
6163
1. Launch the Azure Portal [Azure Portal](https://portal.azure.com/).
6264
2. Enter `Resource Groups` in the top search bar.
6365
@@ -80,4 +82,4 @@
8082
8183
8. Click on `Overview` from the left menu. Then click on `Restart` button in the top menu. Then click on `Yes` in the pop-up message.
8284
83-
![Application Restart](images/fabric/AppServiceRestart.png)
85+
![Application Restart](images/fabric/AppServiceRestart.png) -->

docs/quota_check.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
## Check Quota Availability Before Deployment
22

33
Before deploying the accelerator, **ensure sufficient quota availability** for the required model.
4-
> **For Global Standard | GPT-4o-mini - the capacity to at least 100K tokens for optimal performance.**
4+
> **For Global Standard | GPT-4o-mini - increase the capacity to at least 150K tokens for optimal performance.**
55
66
### Login if you have not done so already
77
```

infra/main.bicep

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ param deploymentType string = 'GlobalStandard'
2121
@description('Name of the GPT model to deploy:')
2222
@allowed([
2323
'gpt-4o-mini'
24-
'gpt-4o'
2524
])
2625
param gptModelName string = 'gpt-4o-mini'
2726

@@ -50,7 +49,7 @@ param embeddingDeploymentCapacity int = 80
5049
param imageTag string = 'latest'
5150

5251
//restricting to these regions because assistants api for gpt-4o-mini is available only in these regions
53-
@allowed(['australiaeast','eastus', 'eastus2','francecentral','japaneast','norwayeast','southindia', 'swedencentral','uksouth', 'westus', 'westus3'])
52+
@allowed(['australiaeast','eastus', 'eastus2','francecentral','japaneast','swedencentral','uksouth', 'westus', 'westus3'])
5453
@description('Azure OpenAI Location')
5554
param AzureOpenAILocation string = 'eastus2'
5655

infra/scripts/quota_check_params.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ az account set --subscription "$AZURE_SUBSCRIPTION_ID"
9393
echo "🎯 Active Subscription: $(az account show --query '[name, id]' --output tsv)"
9494

9595
# Default Regions to check (Comma-separated, now configurable)
96-
DEFAULT_REGIONS="eastus,uksouth,eastus2,northcentralus,westus,westus2,southcentralus,canadacentral,australiaeast,swedencentral"
96+
DEFAULT_REGIONS="australiaeast,eastus,eastus2,francecentral,japaneast,swedencentral,uksouth,westus,westus3"
9797
IFS=',' read -r -a DEFAULT_REGION_ARRAY <<< "$DEFAULT_REGIONS"
9898

9999
# Read parameters (if any)

0 commit comments

Comments
 (0)