Dev changes sync to main #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/Build-your-own-copilot-Solution-Accelerator into psl-workflow-codeowners
Client Advisor | Researcher - SFI Fixes
Researcher | Client Advisor - workflows, code owners and dependabot added to accelerators
Client Advisor | Frontend test cases added
Researcher | Client Advisor - Lint issues fixes
Client Advisor | Backend test cases added
Update WebApp.Dockerfile for Research assistant
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return Response(format_as_ndjson(result), status=status_code) | ||
| else: | ||
|
|
||
| return Response(stream_with_data(body, headers, endpoint, history_metadata), mimetype='text/event-stream') | ||
| return Response( | ||
| stream_with_data(body, headers, endpoint, history_metadata), |
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 6 months ago
To fix the problem, we need to ensure that detailed exception messages are not exposed to the end user. Instead, we should log the detailed exception on the server and return a generic error message to the user. This can be achieved by modifying the exception handling in the fetchUserGroups function to log the exception and yield a generic error message.
- Modify the exception handling in the
fetchUserGroupsfunction to log the exception using theloggingmodule. - Return a generic error message to the user instead of the detailed exception message.
Suggested changeset
1
ResearchAssistant/App/app.py
| @@ -338,3 +338,4 @@ | ||
| except Exception as e: | ||
| yield format_as_ndjson({"error" + str(e)}) | ||
| logging.error("An error occurred: %s", str(e)) | ||
| yield format_as_ndjson({"error": "An internal error has occurred."}) | ||
| else: | ||
| @@ -436,4 +437,4 @@ | ||
| except Exception as e: | ||
| yield format_as_ndjson({"error" + str(e)}) | ||
|
|
||
| logging.error("An error occurred: %s", str(e)) | ||
| yield format_as_ndjson({"error": "An internal error has occurred."}) | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
Prajwal-Microsoft
approved these changes
Nov 26, 2024
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes,