fix: Merging dev fixes into main #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urce-packages build: Downgrade msal[broker] and azure-mgmt-resource package to compatible version
…rsion conflicts (#283)
build: Upgrade azure-ai-ml package to compatible version
* Research assistant backend unit test * Research assistant backend unit test * Research assistant unit test pylint correction * pylint correction * research assistant .yml file * Update test_research_assistant.yml --------- Co-authored-by: Roopan-Microsoft <168007406+Roopan-Microsoft@users.noreply.github.com>
…#287) * Prompt flow version update * Add files via upload * Add files via upload * Add files via upload --------- Co-authored-by: Roopan-Microsoft <168007406+Roopan-Microsoft@users.noreply.github.com>
feat: Dev Image Version Check Test
revert: "feat: Dev Image Version Check Test"
* updated Asset and retirement updated code * minor fix on meeting days * fixed test case * optimized query
Roopan-Microsoft
requested review from
Avijit-Microsoft and
Prajwal-Microsoft
as code owners
There was a problem hiding this comment.
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (1)
- ResearchAssistant/Deployment/scripts/aihub_scripts/requirements.txt: Language not supported
Comments suppressed due to low confidence (1)
ClientAdvisor/App/frontend/src/api/api.ts:238
- The error response should be created directly as a new Response object instead of spreading an empty Response.
const errRes: Response = { ...new Response(), ok: false, status: 500 }
Avijit-Microsoft
approved these changes
Feb 17, 2025
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
get_usersfunction in the backend, and a new utility function in the frontend to handle empty arrays.Workflow updates:
.github/workflows/build-docker.yml: Added a new step to determine the tag name based on the branch name, and updated the Docker build and push steps to use this tag name..github/workflows/test_research_assistant.yml: Created a new workflow for running unit tests on the Research Assistant module, triggered by pushes and pull requests to themainanddevbranches.Backend improvements:
ClientAdvisor/App/app.py: Refactored theget_usersfunction to combine multiple SQL queries into a single statement, improving the efficiency of updating sample data in theClientMeetings,Assets, andRetirementtables. [1] [2]Frontend improvements:
ClientAdvisor/App/frontend/src/api/api.ts: Added a new utility functionisLastObjectNotEmptyto check if the last object in an array is not empty, and used this function to handle empty array cases in thehistoryUpdatefunction. [1] [2]Test updates:
ClientAdvisor/App/tests/test_app.py: Updated thetest_get_users_successtest to include new fieldsClientMeetingDaysDifference,AssetMonthsDifference,StatusMonthsDifference, andDaysDifferencein the mock data.Dependency updates:
ResearchAssistant/Deployment/scripts/aihub_scripts/requirements.txt: Updated the versions ofazure-ai-ml,msal[broker], andazure-mgmt-resourcedependencies.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information