refactor: standardize Bicep resource naming, simplify parameters, and upgrade OpenAI model #531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces significant updates to the infrastructure Bicep templates, focusing on improving resource naming conventions, standardizing parameter handling, and updating dependencies. The most notable changes include the addition of a centralized abbreviations file for consistent naming, the removal of hardcoded default parameter values, and the transition to a new version of the OpenAI model. Below is a categorized summary of the most important changes:
Naming Standardization and Abbreviations
infra/bicep/abbreviations.json
to centralize resource abbreviations for consistent and scalable naming conventions across all Bicep templates.main.bicep
to dynamically generate resource names using abbreviations, such asmanagedIdentity
,storageAccount
, andkeyVault
, by referencing the newabbreviations.json
file. [1] [2] [3]Parameter Simplification
searchServices_byc_cs_name
,HostingPlanName
,WebsiteName
, and others across multiple deployment files to allow for more flexibility during deployment. [1] [2] [3] [4] [5]OpenAI Model Update
deploy_azure_open_ai.bicep
andmain.bicep
fromgpt-35-turbo-16k
togpt-35-turbo
with updated version0125
for improved performance and compatibility. [1] [2]Dependency Updates
main.bicep
to point to thebyoc-researcher
branch for the latest resources.main.json
metadata from0.29.47.4906
to0.33.93.31351
for compatibility with new features.Resource-Specific Enhancements
App Service Plan
,Web App
, andApplication Insights
inmain.bicep
using the new abbreviations file.deploy_azure_ai_service.bicep
anddeploy_ai_search_service.bicep
to use dynamically generated names. [1] [2]These changes enhance maintainability, scalability, and flexibility of the infrastructure deployment process.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information