Skip to content

Commit

Permalink
Version 7.2.3: Fixed crash on attempt to execute a compiled script in…
Browse files Browse the repository at this point in the history
… the wrong V8 runtime; fixed intermittent V8 crash on Windows x86 (GitHub Issue #354); added V8GlobalFlags.DisableBackgroundWork; fixed async function performance (GitHub Issue #356); added a WebAssembly unit test; updated API documentation. Tested with V8 9.9.115.8.
  • Loading branch information
ClearScriptLib committed Mar 5, 2022
1 parent 14f6593 commit 3dc8b92
Show file tree
Hide file tree
Showing 629 changed files with 3,513 additions and 875 deletions.
6 changes: 3 additions & 3 deletions ClearScript/Exports/VersionSymbols.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

#pragma once

#define CLEARSCRIPT_VERSION_STRING "7.2.2"
#define CLEARSCRIPT_VERSION_COMMA_SEPARATED 7,2,2
#define CLEARSCRIPT_VERSION_STRING_INFORMATIONAL "7.2.2"
#define CLEARSCRIPT_VERSION_STRING "7.2.3"
#define CLEARSCRIPT_VERSION_COMMA_SEPARATED 7,2,3
#define CLEARSCRIPT_VERSION_STRING_INFORMATIONAL "7.2.3"
#define CLEARSCRIPT_FILE_FLAGS 0L
10 changes: 5 additions & 5 deletions ClearScript/Properties/AssemblyInfo.Core.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@
[assembly: InternalsVisibleTo("ClearScriptTest")]

[assembly: ComVisible(false)]
[assembly: AssemblyVersion("7.2.2")]
[assembly: AssemblyFileVersion("7.2.2")]
[assembly: AssemblyInformationalVersion("7.2.2")]
[assembly: AssemblyVersion("7.2.3")]
[assembly: AssemblyFileVersion("7.2.3")]
[assembly: AssemblyInformationalVersion("7.2.3")]

namespace Microsoft.ClearScript.Properties
{
internal static class ClearScriptVersion
{
public const string Triad = "7.2.2";
public const string Informational = "7.2.2";
public const string Triad = "7.2.3";
public const string Informational = "7.2.3";
}
}
6 changes: 3 additions & 3 deletions ClearScript/Properties/AssemblyInfo.V8.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
[assembly: InternalsVisibleTo("ClearScriptTest")]

[assembly: ComVisible(false)]
[assembly: AssemblyVersion("7.2.2")]
[assembly: AssemblyFileVersion("7.2.2")]
[assembly: AssemblyInformationalVersion("7.2.2")]
[assembly: AssemblyVersion("7.2.3")]
[assembly: AssemblyFileVersion("7.2.3")]
[assembly: AssemblyInformationalVersion("7.2.3")]
6 changes: 3 additions & 3 deletions ClearScript/Properties/AssemblyInfo.Windows.Core.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
[assembly: InternalsVisibleTo("ClearScriptTest")]

[assembly: ComVisible(false)]
[assembly: AssemblyVersion("7.2.2")]
[assembly: AssemblyFileVersion("7.2.2")]
[assembly: AssemblyInformationalVersion("7.2.2")]
[assembly: AssemblyVersion("7.2.3")]
[assembly: AssemblyFileVersion("7.2.3")]
[assembly: AssemblyInformationalVersion("7.2.3")]
6 changes: 3 additions & 3 deletions ClearScript/Properties/AssemblyInfo.Windows.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
[assembly: InternalsVisibleTo("ClearScriptTest")]

[assembly: ComVisible(false)]
[assembly: AssemblyVersion("7.2.2")]
[assembly: AssemblyFileVersion("7.2.2")]
[assembly: AssemblyInformationalVersion("7.2.2")]
[assembly: AssemblyVersion("7.2.3")]
[assembly: AssemblyFileVersion("7.2.3")]
[assembly: AssemblyInformationalVersion("7.2.3")]
9 changes: 8 additions & 1 deletion ClearScript/V8/V8GlobalFlags.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,13 @@ public enum V8GlobalFlags : uint
/// <summary>
/// Specifies that just-in-time compilation is to be disabled.
/// </summary>
DisableJITCompilation = 0x00000002
DisableJITCompilation = 0x00000002,

/// <summary>
/// Specifies that background work is to be disabled. By default, V8 performs various tasks
/// in the background, accelerating garbage collection, just-in-time compilation, and other
/// activities. Use this option if you encounter issues related to V8's background work.
/// </summary>
DisableBackgroundWork = 0x00000004
}
}
Binary file modified ClearScript/doc/Reference.chm
Binary file not shown.
6 changes: 3 additions & 3 deletions ClearScriptBenchmarks/Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@
[assembly: AssemblyCopyright("(c) Microsoft Corporation")]

[assembly: ComVisible(false)]
[assembly: AssemblyVersion("7.2.2")]
[assembly: AssemblyFileVersion("7.2.2")]
[assembly: AssemblyInformationalVersion("7.2.2")]
[assembly: AssemblyVersion("7.2.3")]
[assembly: AssemblyFileVersion("7.2.3")]
[assembly: AssemblyInformationalVersion("7.2.3")]
6 changes: 3 additions & 3 deletions ClearScriptConsole/Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@
[assembly: AssemblyCopyright("(c) Microsoft Corporation")]

[assembly: ComVisible(false)]
[assembly: AssemblyVersion("7.2.2")]
[assembly: AssemblyFileVersion("7.2.2")]
[assembly: AssemblyInformationalVersion("7.2.2")]
[assembly: AssemblyVersion("7.2.3")]
[assembly: AssemblyFileVersion("7.2.3")]
[assembly: AssemblyInformationalVersion("7.2.3")]
16 changes: 15 additions & 1 deletion ClearScriptTest/BugFixTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ public void BugFix_AutoInt64FromDouble()
}

[TestMethod, TestCategory("BugFix")]
public void BugFix_CompiledScriptResult()
public void BugFix_V8CompiledScriptResult()
{
engine.Script.host = new HostFunctions();
using (var script = ((V8ScriptEngine)engine).Compile("host"))
Expand Down Expand Up @@ -1551,6 +1551,20 @@ function extendHostObject(hostObject) {
Assert.AreEqual(Math.PI, engine.Evaluate("Console.PI"));
}

[TestMethod, TestCategory("BugFix")]
public void BugFix_V8CompiledScript_WrongIsolate()
{
using (var script = ((V8ScriptEngine)engine).Compile("function foo() {}"))
{
using (var tempEngine = new V8ScriptEngine(V8ScriptEngineFlags.EnableDebugging))
{
// ReSharper disable AccessToDisposedClosure
TestUtil.AssertException<ScriptEngineException>(() => tempEngine.Execute(script), false);
// ReSharper restore AccessToDisposedClosure
}
}
}

// ReSharper restore InconsistentNaming

#endregion
Expand Down
Loading

0 comments on commit 3dc8b92

Please sign in to comment.