Skip to content

feat: Standardize Bicep Parameters for Code Modernization #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

VishalS-Microsoft
Copy link
Contributor

Purpose

This pull request introduces several updates to enhance parameter customization and configuration for Azure deployments. The changes focus on improving documentation, refining infrastructure templates, and aligning default parameter values across files.

Documentation Updates:

  • docs/CustomizingAzdParameters.md: Replaced individual parameter setting examples with a comprehensive table listing all customizable parameters, their types, default values, and purposes. Added instructions on how to set parameters using the azd env set command.

Infrastructure Template Enhancements:

  • infra/main.bicep: Added new parameters deploymentType (default: 'GlobalStandard') and llmModel (default: 'gpt-4o') to define the model deployment type and LLM model name directly in the infrastructure template.
  • infra/main.bicep: Removed hardcoded values for deploymentType and llmModel from variable definitions, ensuring these values are now parameter-driven for better flexibility.

Parameter Alignment:

  • infra/main.bicepparam: Updated parameter definitions to align with environment variables, including capacity, deploymentType, and llmModel, ensuring consistency with the documentation and infrastructure templates.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants