-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<generator>
: Various fixes and cleanups
#4471
Merged
StephanTLavavej
merged 11 commits into
microsoft:feature/generator
from
StephanTLavavej:generator-cleanups
Mar 13, 2024
Merged
<generator>
: Various fixes and cleanups
#4471
StephanTLavavej
merged 11 commits into
microsoft:feature/generator
from
StephanTLavavej:generator-cleanups
Mar 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now consistent with the other occurrence of `auto& _Stored_al`.
Add Standard citations. "generator's second argument" was bogus; use "generator's selected reference type" to describe italic-monospace-reference. Then say "an actual reference type" for clarity. "an iterator with \[...\] cannot model indirectly_readable" was confusing because it was describing a bad situation, but the other messages are describing how situations must be good. Rephrase this for clarity.
…s instead of lambdas to make Clang happy.
CaseyCarter
approved these changes
Mar 12, 2024
14bbb8e
into
microsoft:feature/generator
35 checks passed
yronglin
added a commit
to yronglin/STL
that referenced
this pull request
Mar 15, 2024
This reverts commit 14bbb8e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My apologies for the grab-bag PR (slightly excusable for a feature branch).
This starts with trivial followups to #4464, then addresses pre-existing issues that I found:
std::
=>_STD
<cstddef>
forstd::nullptr_t
.__stdcall
to make<generator>
immune to default calling conventions.constexpr size_t _Align
doesn't need to bestatic
.const _Alloc&
.auto& _Stored_al
._RANGES
._Promise
=>_CoroPromise
to avoid intolerable shadowing of<future>
.<coroutine>
. We conventionally never allow template parameters to shadow other machinery like this:STL/stl/inc/future
Lines 1001 to 1002 in d6efe94
throw;
=>_RERAISE;
try/catch/throw
in headers. Using the macros respects_HAS_EXCEPTIONS=0
.generator
'sstatic_assert
s._Dealloc_fn
as_NOEXCEPT_FNPTR
.static
member functions instead of lambdas to make Clang happy.-fno-ms-compatibility
refuses to convert stateless lambdas to__stdcall
function pointers, which I suppose is a defensible choice.