<regex>: Implement collating ranges
#5238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muellerj2
commented
Jan 15, 2025
CaseyCarter
reviewed
Jan 15, 2025
Fix trivial merge conflict in tests/std/test.lst.
StephanTLavavej
approved these changes
Mar 20, 2025
|
Thanks! This makes sense and looks good to me. The comprehensive test coverage is excellent. 😻 I pushed a trivial merge with |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Mar 21, 2025
|
Thanks for sorting out this bug! 😹 🐞 🪄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5204. Follow-up to #5164 and #5209.
When compiled under
/MDor/MDd, the new test cases specific to collating ranges are skipped:/Zc:wchar_t-because the test will fail due to<locale>:std::collate<wchar_t>does not respect collation order when compiled with/MD(d) /Zc:wchar_t-#5236._ITERATOR_DEBUG_LEVELbecause the stack will be corrupted whenstd::collate<wchar_t>::do_transform()is called in the linked DLL.Drive-by changes:
_Parser::_Error()as[[noreturn]]._Matcher::_Skip()and_Matcher::_Do_class(),_STDqualify calls to some free functions and clean up the control flow that translates the current character and converts it to an unsigned value.