-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vectorize remove_copy
and unique_copy
#5355
Open
AlexGuteniev
wants to merge
27
commits into
microsoft:main
Choose a base branch
from
AlexGuteniev:copycats
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Less error prone, especially if implementing _copy someday
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
# Conflicts: # benchmarks/src/unique.cpp # stl/inc/algorithm # stl/src/vector_algorithms.cpp
StephanTLavavej
requested changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚙️ The optimization
remove_copy
andunique_copy
are different from their non-_copy
counterparts in that they don't have room they are allowed to overwrite. This means we can't directly store results from vector registers.The previous attempt #5062 tried to use masked stores to bypass that limitation. Unfortunately, this doesn't perform well for some CPUs. Also the minimum granularity of AVX2 masked store is 32 bits, so it would not work for smaller elements.
This time, temporary storage comes to rescue. The algorithms already use some additional memory (the tables), so why wouldn't it use a bit more. I arbitrarily picked 512 bytes, should be not too much. Each time the temporary buffer is full, it can be copied to the destination with
memcpy
, it should be fast enough for this buffer size.🚫 No
find
beforeremove_copy
In #4987, it was explained that doing
find
beforeremove
is good for both correctness and performance. Originally it was in vectorization code, but during the review @StephanTLavavej observed that it is done in the headers already (#4987 (comment)).For
remove_copy
it is not necessary for correctness, and may be harmful for performance.find
would needcopy
in addition, this will be double pass on the input, which can make the performance worse for large input and memry-bound situation.We may have special handling of the range before the first match in vectorization code, this is another story, and it would not be harmful, but I'm not doing this in the current PR. Maybe later.
So, as we have not called
find
, and so have not checked if value type can even match iterator value type, we need this_Could_compare_equal_to_value_type
check here.✅ Test coverage
Shared with non-
_copy
counterparts to save total tests run time and some lines of code, at the expense with otherwise unnecessary coupling.We check both modified and unmodified destination parts, to make sure unmodified indeed didn't modify.
⏱️ Benchmark results
🥇 Results interpretation
Good improvement!
Not as good as for non-
_copy
counterparts though, asmemcpy
takes some noticeable time.The usual codegen gremlins that cause results variation are observed for non-vectorized tight loops. I've marked the most notorious one with clown. I can't explain that anomality.