Update body background, body background medium, inline-code, and hover-invert colors on dark theme #742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link: preview
This PR updates the body-background color on dark theme. Body-background-medium, inline-code, and hover-invert colors are also updated to maintain sufficient color contrast.
Fluent colors: https://react.fluentui.dev/?path=/docs/theme-colors--docs
Testing
body-background-medium
is lighter thanbody-background
, same as before.colorNeutralBackground1Hover
color on dark theme, #3d3d3d .Class
column. I couldn't find any Fluent guidance on inline code colors, so I picked a bright enough color to make the inline code stand out against the new background. The contrast ratio between the background and inline code block background is 2.013, which is an improvement compared to the previous 1.7~.colorNeutralBackground6
color, which is already the lightest grey color for dark theme amongst all 6colorNeutralBackground
colors. To improve the ratio even more, I see two options:colorNeutralBackground1Hover
, which increases the ratio to 1.339:1Additional information
[Optional]
Contributor checklist