Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filled tag and progress bar colors #746

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Conversation

homing1
Copy link
Contributor

@homing1 homing1 commented Feb 28, 2025

Link: preview

This PR updates the secondary-background-glow-high-contrast theme variable to a slightly darker grey as the previous color is deemed too light by users. It also fixes interactive filled tag close hover divider color.

Figma: https://www.figma.com/design/uVA2amRR71yJZ0GS6RI6zL/%F0%9F%8C%9E-Atlas-Design-Library?node-id=73202-812&p=f&t=Fdfh5RYdQKonWpEA-0

Testing

  1. Visit http://localhost:1111/components/tag.html , review filled tag background color. Compare with https://design.learn.microsoft.com/components/tag.html .
  2. Visit http://localhost:1111/components/progress-bar.html , review progress bar background color. Compare with https://design.learn.microsoft.com/components/progress-bar.html

Expected result: Filled tag and progress bar background color is slightly darker than before.

Additional information

[Optional]

Contributor checklist

  • Did you update the description of this pull request with a review link and test steps?
  • Did you submit a changeset? Changesets are required for all code changes.
  • Does your pull request implement complex UI logic (js/ts)? Consider adding an integration test to test your user flow.
  • Does your pull request add a new page to the documentation site? Add your new page for automated accessibility testing in /integration/tests/accessibility.
  • Does your pull request change any transforms? Did you test they work on right to left?

@homing1 homing1 requested a review from a team as a code owner February 28, 2025 20:25
Copy link

changeset-bot bot commented Feb 28, 2025

🦋 Changeset detected

Latest commit: e7c8a5f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@microsoft/atlas-css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@homing1 homing1 merged commit 494a446 into main Feb 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants