Skip to content

Fix missing tools in logs #6532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

afzalmushtaque
Copy link
Contributor

Fix for LLMCallEvent failing to log "tools" passed to BaseOpenAIChatCompletionClient in autogen_ext.models.openai._openai_client.BaseOpenAIChatCompletionClient

This bug creates problems inspecting why a certain tool was selected/not selected by the LLM as the list of tools available to the LLM is not present in the logs

Why are these changes needed?

Added "tools" to the LLMCallEvent to log tools available to the LLM as these were being missed causing difficulties during debugging LLM tool calls.

Related issue number

Checks

afzalmushtaque and others added 2 commits May 14, 2025 22:55
Fix for LLMCallEvent failing to log "tools" passed to BaseOpenAIChatCompletionClient in autogen_ext.models.openai._openai_client.BaseOpenAIChatCompletionClient 
microsoft#6531
This bug creates problems inspecting why a certain tool was selected/not selected by the LLM as the list of tools available to the LLM is not present in the logs
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.52%. Comparing base (9d29731) to head (d7acecf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6532   +/-   ##
=======================================
  Coverage   79.52%   79.52%           
=======================================
  Files         225      225           
  Lines       16661    16661           
=======================================
  Hits        13249    13249           
  Misses       3412     3412           
Flag Coverage Δ
unittests 79.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ekzhu ekzhu enabled auto-merge (squash) May 16, 2025 00:12
@ekzhu ekzhu merged commit 446da62 into microsoft:main May 16, 2025
64 checks passed
@afzalmushtaque afzalmushtaque deleted the afzalmushtaque-patch-missing-tools-in-logs branch May 16, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants