Skip to content

Allow implicit aws credential setting for AnthropicBedrockChatCompletionClient #6561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025

Conversation

GeorgeEfstathiadis
Copy link
Contributor

Why are these changes needed?

Allows implicit AWS credential setting when using AnthropicBedrockChatCompletionClient in an instance where you have already logged into AWS with SSO and credentials are set as environment variables.

Related issue number

Closes #6560

Checks

Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.52%. Comparing base (bd3b97a) to head (f2721b7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6561   +/-   ##
=======================================
  Coverage   79.52%   79.52%           
=======================================
  Files         225      225           
  Lines       16624    16628    +4     
=======================================
+ Hits        13220    13224    +4     
  Misses       3404     3404           
Flag Coverage Δ
unittests 79.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jackgerrits jackgerrits merged commit 113aca0 into microsoft:main May 21, 2025
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow AnthropicBedrockChatCompletionClient use in an AWS environment
2 participants