From 10d299420cef9537a4f1fad6312435bafef60e5c Mon Sep 17 00:00:00 2001
From: Leonard <92177433+LeonardHd@users.noreply.github.com>
Date: Thu, 28 Mar 2024 17:33:41 +0100
Subject: [PATCH 1/2] ci: fix cd job (#6)

---
 .conventional-commits/GitVersion.yml |  2 ++
 .github/workflows/cd.yml             | 13 ++++++++-----
 .github/workflows/ci-cd.yml          |  1 +
 .github/workflows/ci.yml             |  2 +-
 .github/workflows/e2e.yml            |  2 +-
 5 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/.conventional-commits/GitVersion.yml b/.conventional-commits/GitVersion.yml
index 1965e32d..13a341be 100644
--- a/.conventional-commits/GitVersion.yml
+++ b/.conventional-commits/GitVersion.yml
@@ -1,4 +1,6 @@
 ---
+# setting next-version temporary until 1.0.0 is released
+next-version: 0.0.0
 assembly-versioning-scheme: MajorMinorPatch
 mode: Mainline
 ignore:
diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml
index fe6631e6..38b80852 100644
--- a/.github/workflows/cd.yml
+++ b/.github/workflows/cd.yml
@@ -14,25 +14,28 @@ jobs:
     runs-on: ubuntu-latest
     permissions:
       id-token: write
+      contents: write
     environment:
       name: pypi
       url: https://pypi.org/p/data-factory-testing-framework
     steps:
+      - name: Check out repository
+        uses: actions/checkout@v4
       - name: Download sdist
         uses: actions/download-artifact@v3
         with:
-          name: dist
+          name: sdist
           path: dist
       - name: Download whl
         uses: actions/download-artifact@v3
         with:
           name: whl
           path: dist
+      - name: Create release
+        run: gh release create "v${{ inputs.version }}" --prerelease --target ${{ github.ref }}
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: Publish package distributions to PyPI
         uses: pypa/gh-action-pypi-publish@release/v1
         with:
           packages-dir: ./dist
-      - name: Create release
-        run: gh release create ${{ inputs.version }} --prerelease --target ${{ github.ref }}
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml
index d5737aad..485fd892 100644
--- a/.github/workflows/ci-cd.yml
+++ b/.github/workflows/ci-cd.yml
@@ -11,6 +11,7 @@ jobs:
     if: github.ref == 'refs/heads/main'
     permissions:
       id-token: write
+      contents: write
     uses: ./.github/workflows/cd.yml
     with:
       version: ${{ needs.ci.outputs.version }}
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 20d2ab58..40904757 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -20,7 +20,7 @@ jobs:
           fetch-tags: true
           fetch-depth: 0
       - name: Install GitVersion
-        uses: gittools/actions/gitversion/setup@v0
+        uses: gittools/actions/gitversion/setup@v1.1.1
         with:
           versionSpec: '5.x'
       - name: Determine Version
diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
index ba31ba76..2e8bbaca 100644
--- a/.github/workflows/e2e.yml
+++ b/.github/workflows/e2e.yml
@@ -1,5 +1,5 @@
 ---
-name: CD
+name: E2E
 
 on:
   workflow_call: # yamllint disable-line rule:truthy

From 0b05e9f0067c9060f0e329d378c9496243074696 Mon Sep 17 00:00:00 2001
From: Leonard Herold <92177433+LeonardHd@users.noreply.github.com>
Date: Thu, 28 Mar 2024 12:54:46 +0100
Subject: [PATCH 2/2] feat!: new breaking change

---
 README.md | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/README.md b/README.md
index 012c84f2..d7b1b576 100644
--- a/README.md
+++ b/README.md
@@ -40,6 +40,10 @@ A simple test to validate that the concatenation is working as expected could lo
     assert "https://example.com/some-path" == activity.type_properties["url"].result
    ```
 
+sss
+
+s
+
 ## Why :question:
 
 Data Factory does not support unit testing, nor testing of pipelines locally. Having integration and e2e tests running on an actual Data Factory instance is great, but having unit tests on top of them provides additional means of quick iteration, validation and regression testing. Unit testing with the _Data Factory Testing Framework_ has the following benefits: