Fix: Usability improvements #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
jcamachor
force-pushed
the
main
branch
2 times, most recently
from
868d4f8 to
ff310c5
Compare
|
Thanks for your contribution, @tiemobang ! Somehow I missed this PR, I'll take a look shortly. Please feel free to ping me directly next time. |
jcamachor
requested changes
May 10, 2024
| @@ -23,33 +25,49 @@ | |||
|
|
|||
|
|
|||
| @st.cache_resource | |||
| def get_connection(): | |||
| def get_connection(*, result_dirs: List[str] = None): | |||
| # Either search for results in provided direcotries | |||
There was a problem hiding this comment.
typo: direcotries -> directories
| LST_BENCH_CLASSPATH="$LST_BENCH_HOME/target/*:$LST_BENCH_HOME/target/lib/*:$LST_BENCH_HOME/target/classes/*" | ||
|
|
||
| java -cp $LST_BENCH_CLASSPATH com.microsoft.lst_bench.Driver "$@" | ||
| SPARK_CLASSPATH="${SPARK_HOME}/jars/*" |
There was a problem hiding this comment.
I'm wondering why is the Spark class path included here, i.e., launcher does not set up the engine for tests?
| @@ -36,6 +36,8 @@ To include data from a new system, duplicate one of the directories in the [run | |||
| For a deeper understanding of the directory structure, consult the [README file](/run/README.md). | |||
| The LST-Bench dashboard web app automatically retrieves results from the .duckdb files within those folders and displays them on the dashboard. | |||
|
|
|||
| Alternatively, you can provide your own paths to search for results via commandline arguments, see below. | |||
jcamachor
pushed a commit
that referenced
this pull request
May 15, 2024
- Augment file parser to handle incorrect file paths - Fix: Null handing and custom result paths for dashboard - Fix Packaged schemas and path variables for config files
|
Fixed in 364e21b . Thanks for your contribution, @tiemobang ! |
anjagruenheid
added a commit
that referenced
this pull request
Jul 26, 2024
anjagruenheid
added a commit
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contributes a number of fixes to catch incorrect file paths provided by the user.
Further it extends the dashboard with handling of missing values (NULL values).
Also it introduces variables for the configuration files to refer to common paths: the variable ${LST_BENCH_HOME} for the root directory of the project and the variables ${LIB_PATH}, ${WL_PATH}, ${EXP_PATH}, ${TEL_PATH} to refer to the file path of the configuration files of the library, workload, experiment, and telemetry.