Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Usability improvements #261

Closed
wants to merge 4 commits into from
Closed

Fix: Usability improvements #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7c0f9f
Augment file parser to handle incorrect file paths
Mar 29, 2024
6f56b11
Fix: Null handing and custom result paths for dashboard
Apr 2, 2024
d1ef6f1
Fix Packaged schemas and path variables for config files
Apr 6, 2024
04aafef
Merge branch 'main' into file_path_convenience
jcamachor May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ bin/
# Local configuration file (sdk path, etc)
local.properties

# Python
*.pyc

# Others
*~
.DS_Store
Expand Down
8 changes: 6 additions & 2 deletions launcher.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
#!/bin/bash -e

# Constants
LST_BENCH_HOME="$PWD"
# Directory of the script
export LST_BENCH_HOME="$(dirname "$(readlink -f "$0")")"
LST_BENCH_CLASSPATH="$LST_BENCH_HOME/target/*:$LST_BENCH_HOME/target/lib/*:$LST_BENCH_HOME/target/classes/*"

java -cp $LST_BENCH_CLASSPATH com.microsoft.lst_bench.Driver "$@"
SPARK_CLASSPATH="${SPARK_HOME}/jars/*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering why is the Spark class path included here, i.e., launcher does not set up the engine for tests?

CLASSPATH="${LST_BENCH_CLASSPATH}:${SPARK_CLASSPATH}"

java -cp ${CLASSPATH} com.microsoft.lst_bench.Driver "$@"
3 changes: 3 additions & 0 deletions metrics/app/README.md
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ To include data from a new system, duplicate one of the directories in the [run
For a deeper understanding of the directory structure, consult the [README file](/run/README.md).
The LST-Bench dashboard web app automatically retrieves results from the .duckdb files within those folders and displays them on the dashboard.

Alternatively, you can provide your own paths to search for results via commandline arguments, see below.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!


## Dashboard Development
To run the LST-Bench dashboard locally and test your changes, follow these steps:

Expand Down Expand Up @@ -67,6 +69,7 @@ With the dependencies installed, you can now start the Streamlit app by running

```bash
python -m streamlit run main.py
python -m streamlit run main.py -- --result_dirs DIR1 DIR2 ...
```

This command will launch the LST-Bench dashboard locally in your browser.
Loading
Loading