Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: Settings type #4839

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

youyuanwu
Copy link
Contributor

Description

Add safe wrapper for QUIC_SETTINGS ffi type.
Add setters for each setting entry using macro.
Changed Configuration new() to use new Settings type and removed the manual ffi type.

MISC:
Preview settings is removed/regressed because the auto generated bindings do not have preview apis yet.
Rust code files are accumulated in src dir. We should add a dedicated dir inside src to keep all rust code together. Will do it in a separate PR.

Testing

Added simple test to set settings using setters, and get the settings using ffi type to verify they match.

Documentation

NA

Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.91%. Comparing base (7b2fbaf) to head (0821c07).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4839      +/-   ##
==========================================
- Coverage   87.43%   86.91%   -0.53%     
==========================================
  Files          56       56              
  Lines       17634    17634              
==========================================
- Hits        15419    15327      -92     
- Misses       2215     2307      +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks nibanks added the Language: Rust Related to the Rust interop layer label Feb 24, 2025
@youyuanwu youyuanwu marked this pull request as ready for review February 25, 2025 02:29
@youyuanwu youyuanwu requested a review from a team as a code owner February 25, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language: Rust Related to the Rust interop layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants