Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Extra Keep Alive set in ConnectionStart #4849

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

anrossi
Copy link
Contributor

@anrossi anrossi commented Feb 24, 2025

Description

QuicConnStart sets the keep alive timer, when a client creates a new connection. However, this timer set is unnecessary because QuicConnDrainOperations will update the keep alive timer every time, for example, when the initial packet is set.

Testing

Keep alives are already tested, so no new tests are needed.

Documentation

Nope.

@anrossi anrossi requested a review from a team as a code owner February 24, 2025 20:00
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.99%. Comparing base (2c81e07) to head (fbc0c1f).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4849      +/-   ##
==========================================
- Coverage   87.30%   86.99%   -0.31%     
==========================================
  Files          56       56              
  Lines       17634    17630       -4     
==========================================
- Hits        15396    15338      -58     
- Misses       2238     2292      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks nibanks added the Area: Core Related to the shared, core protocol logic label Feb 24, 2025
@anrossi anrossi merged commit 13e95c6 into main Feb 25, 2025
397 of 399 checks passed
@anrossi anrossi deleted the anrossi/remove-superfluous-keep-alive branch February 25, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Core Related to the shared, core protocol logic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants